Closed
Bug 353748
Opened 19 years ago
Closed 19 years ago
klocwork null ptr dereferences in pki3hack.c
Categories
(NSS :: Libraries, defect, P2)
NSS
Libraries
Tracking
(Not tracked)
RESOLVED
FIXED
3.12
People
(Reporter: nelson, Assigned: alvolkov.bgs)
Details
(Keywords: klocwork)
Attachments
(1 file)
|
2.68 KB,
patch
|
nelson
:
review+
|
Details | Diff | Splinter Review |
Klocwork id 89017
File nss/lib/pki/pki3hack.c
Function STAN_GetNSSCertificate
Pointer 'instance' returned from call to function 'nss_ZAlloc' at line 973
may be NULL and will be dereferenced at line 974.
973 instance = nss_ZNEW(arena, nssCryptokiInstance);
974 instance->token = nssToken_AddRef(PK11Slot_GetNSSToken(cc->slot));
Klocwork ID 89035
File nss/lib/pki/pki3hack.c
Function STAN_ChangeCertTrust
Pointer 'c' returned from call to function 'STAN_GetNSSCertificate' at
line 1035 may be NULL and will be dereferenced by passing argument 1 to
function 'nssTrust_GetCERTCertTrustForCert' at line 1045.
|
Reporter | |
Comment 1•19 years ago
|
||
ID: 89036
Function: STAN_ChangeCertTrust
Location: nss/lib/pki/pki3hack.c : 1067
Pointer 'nssTrust' returned from call to function 'nss_ZAlloc' at line 1061
may be NULL and may be dereferenced at line 1067.
1061 nssTrust = nss_ZNEW(arena, NSSTrust);
1067 nssTrust->object = *pkiob;
|
|
Reporter | |
Updated•19 years ago
|
Priority: -- → P2
Target Milestone: --- → 3.12
|
|
Assignee | |
Comment 2•19 years ago
|
||
Assignee: nobody → alexei.volkov.bugs
Status: NEW → ASSIGNED
Attachment #241201 -
Flags: review?(nelson)
|
|
Reporter | |
Comment 3•19 years ago
|
||
Comment on attachment 241201 [details] [diff] [review]
add checks for NULL
r=nelson for trunk.
Attachment #241201 -
Flags: review?(nelson) → review+
|
|
Assignee | |
Comment 4•19 years ago
|
||
/cvsroot/mozilla/security/nss/lib/pki/pki3hack.c,v <-- pki3hack.c
new revision: 1.92; previous revision: 1.91
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•