Last Comment Bug 353749 - PowerUpSelf tests update for DSA and ECDSA KAT
: PowerUpSelf tests update for DSA and ECDSA KAT
Status: RESOLVED FIXED
:
Product: NSS
Classification: Components
Component: Libraries (show other bugs)
: 3.11.3
: x86 Windows XP
: P1 enhancement (vote)
: 3.11.4
Assigned To: glen beasley
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-09-21 21:58 PDT by glen beasley
Modified: 2006-09-25 13:27 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
DSA and ECDSA udpate (13.98 KB, patch)
2006-09-21 22:15 PDT, glen beasley
no flags Details | Diff | Splinter Review
DSA and ECDSA udpate v2 (13.47 KB, patch)
2006-09-22 10:56 PDT, Wan-Teh Chang
glenbeasley: review+
neil.williams: review+
Details | Diff | Splinter Review

Description glen beasley 2006-09-21 21:58:13 PDT
change DSA_PowerUpSelf test prime modulus p's length to 1024.
add a ECDSA KAT for a binary curve.
Comment 1 glen beasley 2006-09-21 22:15:20 PDT
Created attachment 239613 [details] [diff] [review]
DSA and ECDSA udpate

for DSA KAT increased the size of P to 1024 bits
used nistK283 binary field curve KAT
Comment 2 Wan-Teh Chang 2006-09-22 10:56:09 PDT
Created attachment 239678 [details] [diff] [review]
DSA and ECDSA udpate v2

Glen, your patch is basically correct.  The only problem
I found is that dsa_Q should be 20 bytes, not 24 bytes.
So I removed the four extra 0xda bytes at the end of the
dsa_Q array.

I also made some white space changes, one comment change,
and removed unnecessary parentheses around sizeof.
Comment 3 glen beasley 2006-09-22 11:07:16 PDT
Comment on attachment 239678 [details] [diff] [review]
DSA and ECDSA udpate v2

thanks wan-teh.
Comment 4 Wan-Teh Chang 2006-09-22 11:12:06 PDT
Comment on attachment 239678 [details] [diff] [review]
DSA and ECDSA udpate v2

Neil, please review this patch.  Thanks.
Comment 5 Wan-Teh Chang 2006-09-25 13:27:46 PDT
I checked in the patch on the NSS trunk (NSS 3.12) and
NSS_3_11_BRANCH (NSS 3.11.4).

Note You need to log in before you can comment on or make changes to this bug.