Closed
Bug 353749
Opened 18 years ago
Closed 18 years ago
PowerUpSelf tests update for DSA and ECDSA KAT
Categories
(NSS :: Libraries, enhancement, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
3.11.4
People
(Reporter: glenbeasley, Assigned: glenbeasley)
Details
Attachments
(1 file, 1 obsolete file)
|
13.47 KB,
patch
|
glenbeasley
:
review+
neil.williams
:
review+
|
Details | Diff | Splinter Review |
change DSA_PowerUpSelf test prime modulus p's length to 1024.
add a ECDSA KAT for a binary curve.
|
Assignee | |
Updated•18 years ago
|
Severity: normal → enhancement
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•18 years ago
|
Assignee: nobody → glen.beasley
Status: ASSIGNED → NEW
|
|
Assignee | |
Comment 1•18 years ago
|
||
for DSA KAT increased the size of P to 1024 bits
used nistK283 binary field curve KAT
Attachment #239613 -
Flags: review?(wtchang)
|
||
Comment 2•18 years ago
|
||
Glen, your patch is basically correct. The only problem
I found is that dsa_Q should be 20 bytes, not 24 bytes.
So I removed the four extra 0xda bytes at the end of the
dsa_Q array.
I also made some white space changes, one comment change,
and removed unnecessary parentheses around sizeof.
Attachment #239613 -
Attachment is obsolete: true
Attachment #239678 -
Flags: review?(glen.beasley)
Attachment #239613 -
Flags: review?(wtchang)
|
|
Assignee | |
Comment 3•18 years ago
|
||
Comment on attachment 239678 [details] [diff] [review]
DSA and ECDSA udpate v2
thanks wan-teh.
Attachment #239678 -
Flags: review?(glen.beasley) → review+
|
|
||
Comment 4•18 years ago
|
||
Comment on attachment 239678 [details] [diff] [review]
DSA and ECDSA udpate v2
Neil, please review this patch. Thanks.
Attachment #239678 -
Flags: review?(neil.williams)
|
||
Updated•18 years ago
|
Attachment #239678 -
Flags: review?(neil.williams) → review+
|
|
||
Comment 5•18 years ago
|
||
I checked in the patch on the NSS trunk (NSS 3.12) and
NSS_3_11_BRANCH (NSS 3.11.4).
Status: NEW → RESOLVED
Closed: 18 years ago
Priority: -- → P1
Resolution: --- → FIXED
Target Milestone: --- → 3.11.4
Version: 3.11.4 → 3.11.3
You need to log in
before you can comment on or make changes to this bug.
Description
•