The default bug view has changed. See this FAQ.

PowerUpSelf tests update for DSA and ECDSA KAT

RESOLVED FIXED in 3.11.4

Status

NSS
Libraries
P1
enhancement
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: glen beasley, Assigned: glen beasley)

Tracking

3.11.3
3.11.4
x86
Windows XP

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

13.47 KB, patch
glen beasley
: review+
Neil Williams
: review+
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
change DSA_PowerUpSelf test prime modulus p's length to 1024.
add a ECDSA KAT for a binary curve.
(Assignee)

Updated

11 years ago
Severity: normal → enhancement
Status: NEW → ASSIGNED
(Assignee)

Updated

11 years ago
Assignee: nobody → glen.beasley
Status: ASSIGNED → NEW
(Assignee)

Comment 1

11 years ago
Created attachment 239613 [details] [diff] [review]
DSA and ECDSA udpate

for DSA KAT increased the size of P to 1024 bits
used nistK283 binary field curve KAT
Attachment #239613 - Flags: review?(wtchang)

Comment 2

11 years ago
Created attachment 239678 [details] [diff] [review]
DSA and ECDSA udpate v2

Glen, your patch is basically correct.  The only problem
I found is that dsa_Q should be 20 bytes, not 24 bytes.
So I removed the four extra 0xda bytes at the end of the
dsa_Q array.

I also made some white space changes, one comment change,
and removed unnecessary parentheses around sizeof.
Attachment #239613 - Attachment is obsolete: true
Attachment #239678 - Flags: review?(glen.beasley)
Attachment #239613 - Flags: review?(wtchang)
(Assignee)

Comment 3

11 years ago
Comment on attachment 239678 [details] [diff] [review]
DSA and ECDSA udpate v2

thanks wan-teh.
Attachment #239678 - Flags: review?(glen.beasley) → review+

Comment 4

11 years ago
Comment on attachment 239678 [details] [diff] [review]
DSA and ECDSA udpate v2

Neil, please review this patch.  Thanks.
Attachment #239678 - Flags: review?(neil.williams)

Updated

11 years ago
Attachment #239678 - Flags: review?(neil.williams) → review+

Comment 5

11 years ago
I checked in the patch on the NSS trunk (NSS 3.12) and
NSS_3_11_BRANCH (NSS 3.11.4).
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Priority: -- → P1
Resolution: --- → FIXED
Target Milestone: --- → 3.11.4
Version: 3.11.4 → 3.11.3
You need to log in before you can comment on or make changes to this bug.