klocwork null pointer dereference in p7decode.c

RESOLVED FIXED in 3.12

Status

NSS
Libraries
P2
normal
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Nelson Bolyard (seldom reads bugmail), Assigned: Alexei Volkov)

Tracking

({klocwork})

trunk
3.12
klocwork

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1.05 KB, patch
Nelson Bolyard (seldom reads bugmail)
: review+
Details | Diff | Splinter Review
Klocwork id 88036
File     nss/lib/pkcs7/p7decode.c 
Function SEC_PKCS7DecodeItem

Pointer 'p7dcx' returned from call to function 'SEC_PKCS7DecoderStart' at 
line 1240 may be NULL and will be dereferenced by passing argument 1 to 
function 'SEC_PKCS7DecoderUpdate' at line 1242.

1240 p7dcx = SEC_PKCS7DecoderStart(cb, cb_arg, pwfn, pwfn_arg, decrypt_key_cb, 
1241				  decrypt_key_cb_arg, decrypt_allowed_cb); 
1242 (void) SEC_PKCS7DecoderUpdate(p7dcx, (char *) p7item->data, p7item->len); 
1243 return SEC_PKCS7DecoderFinish(p7dcx);
(Assignee)

Comment 1

11 years ago
Created attachment 240987 [details] [diff] [review]
check p7dcx for null value
Assignee: nobody → alexei.volkov.bugs
Status: NEW → ASSIGNED
Attachment #240987 - Flags: review?(nelson)
(Reporter)

Comment 2

11 years ago
Comment on attachment 240987 [details] [diff] [review]
check p7dcx for null value 

r=nelson
Attachment #240987 - Flags: review?(nelson) → review+
(Reporter)

Updated

11 years ago
Priority: -- → P2
Target Milestone: --- → 3.12
(Assignee)

Comment 3

11 years ago
/cvsroot/mozilla/security/nss/lib/pkcs7/p7decode.c,v  <--  p7decode.c
new revision: 1.23; previous revision: 1.22
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.