A recurring Allday event is treated as normal event (e.g. in day view it covers the whole view). Works in 2006092106 Doesn't work in 2006092205 Steps to reproduce: 1. create recurring allday event (e.g. birthday) 2. switch to day view result: events spans the whole day this happens in Sunbird and Lightning (latest hourly)
From reading the code, this ought to be a regression from bug 349788, which seems to fail to restore the isDate setting (in convertDate) on the dates it returns for occurrences.
So this backs out most of the fix from bug 349788, and reimplements it differently. Only changing aRangeEnd to be a datetime object appears to be enough to fix bug 349788 and prevent this bug from occurring.
*** Bug 353855 has been marked as a duplicate of this bug. ***
Flags: blocking0.3? → blocking0.3+
Summary: recurring allday events are screwed up → Recurring all-day events are shown from 00:00 to 24:00 (allday)
Whiteboard: [patch in hand][needs review ctalbert dmose]
Comment on attachment 239685 [details] [diff] [review] rev0 - Ensures the end date used in ritem.getOccurrences is a datetime object R+ on this. We probably need to revert this change and make the permanent fix to the C++ layer in calIRecurrenceRule.
Attachment #239685 - Flags: first-review?(cmtalbert) → first-review+
Comment on attachment 239685 [details] [diff] [review] rev0 - Ensures the end date used in ritem.getOccurrences is a datetime object Looks good; the real fix is going to be in a spin off bug which I believe ctalbert is filing.
Attachment #239685 - Flags: second-review?(dmose) → second-review+
Patch checked in on MOZILLA_1_8_BRANCH and trunk. -> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060929 Sunbird/0.3
Status: RESOLVED → VERIFIED
Whiteboard: [patch in hand][needs review ctalbert dmose] → [patch in hand][needs review ctalbert dmose][litmus testcase wanted]
Whiteboard: [patch in hand][needs review ctalbert dmose][litmus testcase wanted] → [litmus testcase wanted]
You need to log in before you can comment on or make changes to this bug.