353857 - getCurrentNextOrPreviousRecurrence "Not enough arguments" exception

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Matthew (lilmatt) Willis]

Moving a recurring item can throw the following exception:

JavaScript error: , line 0: uncaught exception: [Exception... "Not enough arguments"  nsresult: "0x80570001 (NS_ERROR_XPC_NOT_ENOUGH_ARGS)"  location: "JS frame :: chrome://calendar/content/calendarUtils.js :: getCurrentNextOrPreviousRecurrence :: line 279"  data: no]

Comment 1

[Matthew (lilmatt) Willis]

Attachment: rev0 - adds another arg

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 239692 [details] [diff] [review]
rev0 - adds another arg

I wonder if this is actually an XPConnect bug.  The |retval| in the IDL _should_ make it so that passing in a fifth parameter is unnecessary.

Comment 3

[Joey Minta]

(In reply to comment #2)
It's not an XP-Connect bug.  There are 2 out-params, so one of them needs to be passed in as an in param object.  The problem here is that arg 3 (aMaxCount) should be 0.  (Passing in an empty object isn't exactly correct.)

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 239692 [details] [diff] [review]
rev0 - adds another arg

Good catch; I totally missed that.

Comment 5

[Matthew (lilmatt) Willis]

Attachment: rev1 - jminta's revenge

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 239723 [details] [diff] [review]
rev1 - jminta's revenge

r=dmose

Comment 7

[cmtalbert]

Comment on attachment 239723 [details] [diff] [review]
rev1 - jminta's revenge

looks good.

Comment 8

[Matthew (lilmatt) Willis]

Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED

Comment 9

[Damian Szczepanik]

verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060929 Sunbird/0.3