Closed Bug 353857 Opened 14 years ago Closed 14 years ago

getCurrentNextOrPreviousRecurrence "Not enough arguments" exception

Categories

(Calendar :: Calendar Views, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
Sunbird 0.3

People

(Reporter: mattwillis, Assigned: mattwillis)

Details

Attachments

(1 file, 1 obsolete file)

Moving a recurring item can throw the following exception:

JavaScript error: , line 0: uncaught exception: [Exception... "Not enough arguments"  nsresult: "0x80570001 (NS_ERROR_XPC_NOT_ENOUGH_ARGS)"  location: "JS frame :: chrome://calendar/content/calendarUtils.js :: getCurrentNextOrPreviousRecurrence :: line 279"  data: no]
Attached patch rev0 - adds another arg (obsolete) — Splinter Review
Assignee: nobody → lilmatt
Status: NEW → ASSIGNED
Attachment #239692 - Flags: second-review?(dmose)
Attachment #239692 - Flags: first-review?(cmtalbert)
Comment on attachment 239692 [details] [diff] [review]
rev0 - adds another arg

I wonder if this is actually an XPConnect bug.  The |retval| in the IDL _should_ make it so that passing in a fifth parameter is unnecessary.
Attachment #239692 - Flags: second-review?(dmose) → second-review+
(In reply to comment #2)
It's not an XP-Connect bug.  There are 2 out-params, so one of them needs to be passed in as an in param object.  The problem here is that arg 3 (aMaxCount) should be 0.  (Passing in an empty object isn't exactly correct.)
Comment on attachment 239692 [details] [diff] [review]
rev0 - adds another arg

Good catch; I totally missed that.
Attachment #239692 - Flags: second-review+ → second-review-
Attachment #239692 - Attachment is obsolete: true
Attachment #239723 - Flags: second-review?(dmose)
Attachment #239723 - Flags: first-review?(cmtalbert)
Attachment #239692 - Flags: first-review?(cmtalbert)
Comment on attachment 239723 [details] [diff] [review]
rev1 - jminta's revenge

r=dmose
Attachment #239723 - Flags: second-review?(dmose) → second-review+
Comment on attachment 239723 [details] [diff] [review]
rev1 - jminta's revenge

looks good.
Attachment #239723 - Flags: first-review?(cmtalbert) → first-review+
Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060929 Sunbird/0.3
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.