Closed Bug 353864 Opened 18 years ago Closed 18 years ago

Location and search bar still natively themed on trunk

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 3 alpha1

People

(Reporter: ispiked, Assigned: asaf)

References

Details

Attachments

(2 files, 1 obsolete file)

Screenshot
20.05 KB, image/png
Details
another try
8.05 KB, patch
Gavin
: review+
Details | Diff | Splinter Review 
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060922 Minefield/3.0a1

The location and search bar are not "themed" like they are on branch. They're still natively themed.
Attached image Screenshot — 

    
    

    
  
Hrm... looking at dbaron's screenshot in this blog post [0], it looks like they are in his build. I remember Myk saying something about needing to clobber to get these changes to be picked up...

[0] http://dbaron.org/log/2006-09#d20060921

    
    

    
  
Hrm, i didn't sync gmomestripe.

    
    

    
  
I see this in my build too (they are still native), though I haven't clobbered so if Adam's recollection in comment 2 is correct, that would be it.

    
  
Assignee: nobody → mano
Blocks: 353673

    
    

    
  

      
      
      
      

        Attached patch
          
          
        untested patch for both themes (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #241243 -
        Flags: review?(gavin.sharp)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        another try
        — 
          — Splinter Review
      

    


  

        Attachment #241243 -
        Attachment is obsolete: true

        Attachment #241245 -
        Flags: review?(gavin.sharp)

        Attachment #241243 -
        Flags: review?(gavin.sharp)

    
    

    
  
Comment on attachment 241245 [details] [diff] [review]
another try

Tested this on winstripe, looks fine, but I notice that there's no hover effect like on the branch.

        Attachment #241245 -
        Flags: review?(gavin.sharp) → review+

    
    

    
  
I will file a bug on the hover issue.

mozilla/toolkit/themes/gnomestripe/global/autocomplete.css delete
mozilla/toolkit/themes/gnomestripe/global/jar.mn 1.13
mozilla/toolkit/themes/winstripe/global/autocomplete.css 1.10
Status: NEW → RESOLVED
Closed: 18 years ago
OS: Linux → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 alpha1

    
    

    
  
(In reply to comment #8)
> I will file a bug on the hover issue.

Mano: did you file a bug for this?

    
    

    
  
Filed now, see bug 359056

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: