353873 - Checkin for bug 344323 broke OS/2 build

Status: RESOLVED FIXED

(Core Graveyard :: Widget: OS/2, defect)

Description

[Walter Meinl]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9a1) Gecko/20060922 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9a1) Gecko/20060922 Minefield/3.0a1

Due to check-in of bug344323 OS/2 build is broken in nsScreenManagerOS2.cpp (as also gtk was). I guess OS/2 default is having only one screen (am I right?). I'd suggest to handle it like vlad did with gtk or Mac, solution would be not_implemented. Patch according to vlad's patches to follow.


Reproducible: Always

Comment 1

[Walter Meinl]

Attachment: as said return not implemented

Comment 2

[Walter Meinl]

Just to specify vlads checkin for unbreaking gtk1 builds
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=nsScreenManagerGtk.cpp&branch=&root=/cvsroot&subdir=mozilla/widget/src/gtk&command=DIFF_FRAMESET&rev1=1.12&rev2=1.13

Comment 3

[Adam Guthrie]

You should ask Vlad to just check this in as a bustage fix.

Comment 4

[Walter Meinl]

Andy, Mike, Peter could you confirm (or not) that the suggested fix is the proper solution for OS/2

Comment 5

[Walter Meinl]

vlad got confirmation from the mailinglist that it would be ok to check the bustage fix in, could you please do it I have no rights to do so, thanks

Comment 6

[Mike Kaply [:mkaply]]

checked in.