klocwork bugs in stanpcertdb.c

RESOLVED FIXED in 3.12

Status

NSS
Libraries
P2
normal
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Nelson Bolyard (seldom reads bugmail), Assigned: Alexei Volkov)

Tracking

({klocwork})

trunk
3.12
klocwork

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1.76 KB, patch
Nelson Bolyard (seldom reads bugmail)
: review+
Details | Diff | Splinter Review
ID:       92611
Function: SEC_DeletePermCertificate
Location: nss/lib/certdb/stanpcertdb.c : 96

Pointer 'c' returned from call to function 'STAN_GetNSSCertificate' at 
line 93 may be NULL and will be dereferenced by passing argument 1 to 
function 'NSSCertificate_DeleteStoredObject' at line 96.

93	    NSSCertificate *c = STAN_GetNSSCertificate(cert); 
96	    nssrv = NSSCertificate_DeleteStoredObject(c, NULL); 

----

ID:       90018
Function: __CERT_AddTempCertToPerm
Location: nss/lib/certdb/stanpcertdb.c : 161

Pointer 'c' returned from call to function 'STAN_GetNSSCertificate' at 
line 157 may be NULL and will be dereferenced at line 161.

157	    NSSCertificate *c = STAN_GetNSSCertificate(cert); 
161	    context = c->object.cryptoContext;
(Reporter)

Updated

11 years ago
Priority: -- → P2
Target Milestone: --- → 3.12
(Assignee)

Comment 1

11 years ago
Created attachment 242944 [details] [diff] [review]
check cert pointer for NULL
Assignee: nobody → alexei.volkov.bugs
Status: NEW → ASSIGNED
Attachment #242944 - Flags: review?(nelson)
(Reporter)

Comment 2

11 years ago
Comment on attachment 242944 [details] [diff] [review]
check cert pointer for NULL

r=nelson
Attachment #242944 - Flags: review?(nelson) → review+
(Assignee)

Comment 3

11 years ago
/cvsroot/mozilla/security/nss/lib/certdb/stanpcertdb.c,v  <--  stanpcertdb.c
new revision: 1.73; previous revision: 1.72
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.