Last Comment Bug 353903 - klocwork oom crash in softoken/keydb.c
: klocwork oom crash in softoken/keydb.c
Status: RESOLVED FIXED
: klocwork
Product: NSS
Classification: Components
Component: Libraries (show other bugs)
: trunk
: All All
: P2 normal (vote)
: 3.12
Assigned To: Alexei Volkov
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-09-22 17:40 PDT by Nelson Bolyard (seldom reads bugmail)
Modified: 2006-10-09 15:28 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
return from function if unable to create a new handle (954 bytes, patch)
2006-10-04 14:04 PDT, Alexei Volkov
nelson: review+
Details | Diff | Review

Description Nelson Bolyard (seldom reads bugmail) 2006-09-22 17:40:59 PDT
ID:       92762
Function: nsslowkey_OpenKeyDB
Location: nss/lib/softoken/keydb.c : 1093

Pointer 'handle' returned from call to function 'nsslowkey_NewHandle' at 
line 1084 may be NULL and may be dereferenced at line 1093.

1084	    handle = nsslowkey_NewHandle(NULL); 
1093	    handle->appname = appName ? PORT_Strdup(appName) : NULL ;
Comment 1 Alexei Volkov 2006-10-04 14:04:29 PDT
Created attachment 241221 [details] [diff] [review]
return from function if unable to create a new handle
Comment 2 Nelson Bolyard (seldom reads bugmail) 2006-10-04 14:45:41 PDT
Comment on attachment 241221 [details] [diff] [review]
return from function if unable to create a new handle

r=nelson
Comment 3 Alexei Volkov 2006-10-09 15:28:22 PDT
/cvsroot/mozilla/security/nss/lib/softoken/keydb.c,v  <--  keydb.c
new revision: 1.49; previous revision: 1.48

Note You need to log in before you can comment on or make changes to this bug.