Closed
Bug 353903
Opened 19 years ago
Closed 19 years ago
klocwork oom crash in softoken/keydb.c
Categories
(NSS :: Libraries, defect, P2)
NSS
Libraries
Tracking
(Not tracked)
RESOLVED
FIXED
3.12
People
(Reporter: nelson, Assigned: alvolkov.bgs)
Details
(Keywords: klocwork)
Attachments
(1 file)
|
954 bytes,
patch
|
nelson
:
review+
|
Details | Diff | Splinter Review |
ID: 92762
Function: nsslowkey_OpenKeyDB
Location: nss/lib/softoken/keydb.c : 1093
Pointer 'handle' returned from call to function 'nsslowkey_NewHandle' at
line 1084 may be NULL and may be dereferenced at line 1093.
1084 handle = nsslowkey_NewHandle(NULL);
1093 handle->appname = appName ? PORT_Strdup(appName) : NULL ;
|
Reporter | |
Updated•19 years ago
|
Priority: -- → P2
Target Milestone: --- → 3.12
|
|
Assignee | |
Comment 1•19 years ago
|
||
Assignee: nobody → alexei.volkov.bugs
Status: NEW → ASSIGNED
Attachment #241221 -
Flags: review?(nelson)
|
|
Reporter | |
Comment 2•19 years ago
|
||
Comment on attachment 241221 [details] [diff] [review]
return from function if unable to create a new handle
r=nelson
Attachment #241221 -
Flags: review?(nelson) → review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
/cvsroot/mozilla/security/nss/lib/softoken/keydb.c,v <-- keydb.c
new revision: 1.49; previous revision: 1.48
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•