klocwork oom crash in softoken/keydb.c

RESOLVED FIXED in 3.12

Status

NSS
Libraries
P2
normal
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Nelson Bolyard (seldom reads bugmail), Assigned: Alexei Volkov)

Tracking

({klocwork})

trunk
3.12
klocwork

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

ID:       92762
Function: nsslowkey_OpenKeyDB
Location: nss/lib/softoken/keydb.c : 1093

Pointer 'handle' returned from call to function 'nsslowkey_NewHandle' at 
line 1084 may be NULL and may be dereferenced at line 1093.

1084	    handle = nsslowkey_NewHandle(NULL); 
1093	    handle->appname = appName ? PORT_Strdup(appName) : NULL ;
(Reporter)

Updated

11 years ago
Priority: -- → P2
Target Milestone: --- → 3.12
(Assignee)

Comment 1

11 years ago
Created attachment 241221 [details] [diff] [review]
return from function if unable to create a new handle
Assignee: nobody → alexei.volkov.bugs
Status: NEW → ASSIGNED
Attachment #241221 - Flags: review?(nelson)
(Reporter)

Comment 2

11 years ago
Comment on attachment 241221 [details] [diff] [review]
return from function if unable to create a new handle

r=nelson
Attachment #241221 - Flags: review?(nelson) → review+
(Assignee)

Comment 3

11 years ago
/cvsroot/mozilla/security/nss/lib/softoken/keydb.c,v  <--  keydb.c
new revision: 1.49; previous revision: 1.48
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.