Closed Bug 353904 Opened 18 years ago Closed 18 years ago

klocwork Null ptr deref in secasn1d.c

Categories

(NSS :: Libraries, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: nelson, Assigned: nelson)

Details

(Keywords: klocwork)

Attachments

(1 file)

ID:       89618
Function: sec_asn1d_next_in_sequence
Location: nss/lib/util/secasn1d.c : 2025

Pointer 'child' returned from call to function 'sec_asn1d_init_state_based_on_template' at line 2023 may be NULL 
and may be dereferenced at line 2025.

2023		child = sec_asn1d_init_state_based_on_template (child); 
2024		if (child_missing) { 
2025		    child->place = afterIdentifier;
Priority: -- → P2
Target Milestone: --- → 3.12
Attached patch patch v1Splinter Review
Seems like this should do it.
Attachment #244155 - Flags: review?(alexei.volkov.bugs)
Comment on attachment 244155 [details] [diff] [review]
patch v1

looks appropriate
Attachment #244155 - Flags: review?(alexei.volkov.bugs) → review+
Assignee: nobody → nelson
Checking in secasn1d.c; new revision: 1.37; previous revision: 1.36
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: