klocwork Null ptr deref in secasn1d.c

RESOLVED FIXED in 3.12

Status

NSS
Libraries
P2
normal
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Nelson Bolyard (seldom reads bugmail), Assigned: Nelson Bolyard (seldom reads bugmail))

Tracking

({klocwork})

trunk
3.12
klocwork

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

ID:       89618
Function: sec_asn1d_next_in_sequence
Location: nss/lib/util/secasn1d.c : 2025

Pointer 'child' returned from call to function 'sec_asn1d_init_state_based_on_template' at line 2023 may be NULL 
and may be dereferenced at line 2025.

2023		child = sec_asn1d_init_state_based_on_template (child); 
2024		if (child_missing) { 
2025		    child->place = afterIdentifier;
(Assignee)

Updated

11 years ago
Priority: -- → P2
Target Milestone: --- → 3.12
(Assignee)

Comment 1

11 years ago
Created attachment 244155 [details] [diff] [review]
patch v1

Seems like this should do it.
Attachment #244155 - Flags: review?(alexei.volkov.bugs)

Comment 2

11 years ago
Comment on attachment 244155 [details] [diff] [review]
patch v1

looks appropriate
Attachment #244155 - Flags: review?(alexei.volkov.bugs) → review+

Updated

11 years ago
Assignee: nobody → nelson
(Assignee)

Comment 3

11 years ago
Checking in secasn1d.c; new revision: 1.37; previous revision: 1.36
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.