Last Comment Bug 353904 - klocwork Null ptr deref in secasn1d.c
: klocwork Null ptr deref in secasn1d.c
Status: RESOLVED FIXED
: klocwork
Product: NSS
Classification: Components
Component: Libraries (show other bugs)
: trunk
: All All
: P2 normal (vote)
: 3.12
Assigned To: Nelson Bolyard (seldom reads bugmail)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-09-22 17:43 PDT by Nelson Bolyard (seldom reads bugmail)
Modified: 2007-01-03 04:58 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch v1 (846 bytes, patch)
2006-10-30 17:44 PST, Nelson Bolyard (seldom reads bugmail)
alvolkov.bgs: review+
Details | Diff | Review

Description Nelson Bolyard (seldom reads bugmail) 2006-09-22 17:43:48 PDT
ID:       89618
Function: sec_asn1d_next_in_sequence
Location: nss/lib/util/secasn1d.c : 2025

Pointer 'child' returned from call to function 'sec_asn1d_init_state_based_on_template' at line 2023 may be NULL 
and may be dereferenced at line 2025.

2023		child = sec_asn1d_init_state_based_on_template (child); 
2024		if (child_missing) { 
2025		    child->place = afterIdentifier;
Comment 1 Nelson Bolyard (seldom reads bugmail) 2006-10-30 17:44:03 PST
Created attachment 244155 [details] [diff] [review]
patch v1

Seems like this should do it.
Comment 2 Alexei Volkov 2006-11-02 10:09:30 PST
Comment on attachment 244155 [details] [diff] [review]
patch v1

looks appropriate
Comment 3 Nelson Bolyard (seldom reads bugmail) 2007-01-03 04:58:05 PST
Checking in secasn1d.c; new revision: 1.37; previous revision: 1.36

Note You need to log in before you can comment on or make changes to this bug.