353953 - Fixes for Dutch Firefox 2.0 RC2 (Pref/update window size and help)

Status: RESOLVED FIXED

(Mozilla Localizations :: nl / Dutch, defect)

Description

[Ton [:Tonnes]]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1) Gecko/20060921 BonEcho/2.0
Build Identifier: 

- Preference window width is way too big, ever since 1.5 but now even worse
- Update window width is too small, making Accept lines exactly the same, vertical scrollbar not visible and text partly unreadable in major update
- A few tiny fixes for Help doc, one of them being cosmetic as well as platform-specific (also in en-US)
- Inconsistent translation of 'preference name' (by 1 character)

Note: preference window size has only been changed for Windows (using the Dialog sizing script in fact). If anyone is able/willing to change the proper values for Mac and Gnome/linux, please attach another patch.
Note 2: the width for updates.dtd was checked by visibily and on Windows, but the +3 for Mac was done presuming this is ok. Please anyone check on a Mac if this value is ok. Checking on linux would probably be wise too.

Reproducible: Always

Comment 1

[Ton [:Tonnes]]

Attachment: Fix for widths

Comment 2

[Ton [:Tonnes]]

Attachment: Fix for Help

Comment 3

[Ton [:Tonnes]]

Attachment: Fix for preference name

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 239787 [details] [diff] [review]
Fix for widths

[nl] win pref and updates dialog size fixes approved for RC2

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 239789 [details] [diff] [review]
Fix for preference name

[nl] spelling fix approved for RC2

Comment 6

[Tim Maks van den Broek [:mad_maks]]

Comment on attachment 239787 [details] [diff] [review]
Fix for widths

patch applied to the branch and trunk

Comment 7

[Tim Maks van den Broek [:mad_maks]]

Comment on attachment 239789 [details] [diff] [review]
Fix for preference name

patch applied to the branch  and the trunk

Comment 8

[Ton [:Tonnes]]

(In reply to comment #2)
> Created an attachment (id=239788) [edit]
> Fix for Help

Hold on checking this in - see bug 354045.

Comment 9

[Ton [:Tonnes]]

Attachment: Fix for Help v2

<em></em> gewijzigd

Comment 10

[Axel Hecht [:Pike]]

Comment on attachment 239926 [details] [diff] [review]
Fix for Help v2

[nl] approval for small help fixes for RC2

Comment 11

[Tim Maks van den Broek [:mad_maks]]

Comment on attachment 239926 [details] [diff] [review]
Fix for Help v2

patch applied to the branch and the trunk

Comment 12

[Tim Maks van den Broek [:mad_maks]]

all fixes are in, thanks all

Comment 13

[Axel Hecht [:Pike]]

Could you please check if these bugs were landed? I see check-ins, but the check-in comments don't refer to bug numbers.

Please add the fixed1.8.1 keyword if so, and change that to verified1.8.1 if you have VERIFIED the fixes on an RC2 or 3.

Comment 14

[Ton [:Tonnes]]

Verified on Mozilla/5.0 (Windows; U; Win98; nl; rv:1.8.1) Gecko/20061003 Firefox/2.0.