353987 - missing alternate link in atom feed causes unhandled exception

Status: RESOLVED FIXED

(MailNews Core :: Feed Reader, defect)

Description

[Tuukka Tolvanen (sp3000)]

When subscribing to an atom feed where the feed element does not have a link rel="alternate" child, tbird fails to subscribe, and ui is left with progress bar + status message  "Verifying the RSS feed..."

Virhe: [Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIRDFService.GetLiteral]"  nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame :: chrome://messenger-newsblog/content/Feed.js :: anonymous :: line 290"  data: no]
Lähdetiedosto: chrome://messenger-newsblog/content/Feed.js
Rivi: 290

I don't think rfc 4287 requires that one, and regardless the error should be handled better.

tbird trunk 20060915 linux

Comment 1

[Magnus Melin [:mkmelin]]

Got a sample URL?

Comment 2

[Tuukka Tolvanen (sp3000)]

Attachment: working example feed

not really since I came across this while piling a feed hack on top of a forum hack... but here's the first google hit of an atom feed

Comment 3

[Tuukka Tolvanen (sp3000)]

Attachment: failing example feed

...and same with feed/link rel=alternate removed

Comment 4

[alta88]

this may be related, in the general 'not handling bad feeds' department..

the following XML error will cause all further (valid) subscription attempts to fail, requiring a Tb restart.

Error: prefix not bound to a namespace
Source file: http://planetdma.blogspot.com/atom.xml
Line: 154, Column: 1
Source code:
<o:p> ^

Comment 5

[Kaz Nishimura]

This also applies to 2.0 Beta 2 (on Windows).

エラー: [Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIRDFService.GetLiteral]"  nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame :: chrome://messenger-newsblog/content/Feed.js :: anonymous :: line 287"  data: no]
ソースファイル: chrome://messenger-newsblog/content/Feed.js
行: 287

Google Groups Atom feeds do not work, while RSS feeds do.

Comment 6

[Tuukka Tolvanen (sp3000)]

Attachment: patch1

patch1: in parseAsAtomIETF, don't set a null aFeed.link; fixes subscribing to e.g. http://groups.google.com/group/mozilla.dev.planning/feed/atom_v1_0_msgs.xml

Comment 7

[Tuukka Tolvanen (sp3000)]

Attachment: patch2

...on second thought, patch1 is odd because the same courtesy is not paid to other nonrequired things in parseAsAtomIETF as they aren't susceptible to death by rdf; this instead nullchecks right before talking to rdf, i.e. Feed.item = null shall mean not setting one.

Comment 8

[Scott MacGregor]

Comment on attachment 253899 [details] [diff] [review]
patch2

thanks tuukka!