klocwork bugs in freebl

RESOLVED FIXED in 3.12

Status

NSS
Libraries
P2
normal
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Nelson Bolyard (seldom reads bugmail), Assigned: Alexei Volkov)

Tracking

({klocwork})

trunk
3.12
klocwork

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1.04 KB, patch
Nelson Bolyard (seldom reads bugmail)
: review+
Details | Diff | Splinter Review
ID:       91218
Function: mp_div
Location: nss/lib/freebl/mpi/mpi.c : 1006

Dereference of pointer 'a' at line 1006 before NULL check at line 1009

1006	  mp_sign  signA = MP_SIGN(a); 
1007	  mp_sign  signB = MP_SIGN(b); 
1008	 
1009	  ARGCHK(a != NULL && b != NULL, MP_BADARG); 

----

ID 91219

Same issue as above, but for pointer variable b at line 1007, 1009
(Assignee)

Comment 1

11 years ago
Created attachment 240226 [details] [diff] [review]
check args before deref pointers
Assignee: nobody → alexei.volkov.bugs
Status: NEW → ASSIGNED
Attachment #240226 - Flags: review?(nelson)
(Reporter)

Updated

11 years ago
Priority: -- → P2
Target Milestone: --- → 3.12
(Reporter)

Comment 2

11 years ago
Comment on attachment 240226 [details] [diff] [review]
check args before deref pointers

r=nelson for trunk
Attachment #240226 - Flags: review?(nelson) → review+
(Assignee)

Comment 3

11 years ago
/cvsroot/mozilla/security/nss/lib/freebl/mpi/mpi.c,v  <--  mpi.c
new revision: 1.45; previous revision: 1.44
(Assignee)

Updated

11 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.