354013 - Investigate hacking Camino into shipping branding

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Per discussions in bug 343837 and on irc, and due to the unlikeliness of the NSS strings being fixed or of Core shipping a default branding package any time soon (bug 302309 comment 18), Håkan has volunteered to do some investigation of hacking us into shipping branding (for 1.1).

Comment 1

[Stuart Morgan]

Now that we have a livable workaround for bug 343837, should we push this out past 1.1?

Comment 2

[Stuart Morgan]

So it doesn't get lost, see bug 343837 for some discussion of what is involved here.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Yeah, we should look at this for 2.0, since bugs are starting to crop up in Gecko 1.9, but now we should be safe until then.

Comment 4

[Håkan Waara]

I'm putting my Camino work on ice for the moment. Sorry guys :(

Comment 5

[Stuart Morgan]

Not going to happen for 2.0; hopefully 1.9.0 is stable enough that it won't come up again.

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Hack

Since I learned how to do this some time ago (at least in the hack form), and since I needed to have brand.dtd defined for some ultimately-futile tilting-at-windmills in other places tonight, I present to you our very own branding hack.

TBH, I'm not sure it's worth our time/bytes to ship this (and although I still hold to what I said in the parenthetical last paragraph of bug 343837 comment 11, the fact of the matter is that "embedding" these days is "non-Mozilla.org XUL apps"--who are completely broken in Core XUL files without branding--and us), but since I had the changes anyway, it seemed silly to just toss them without making a patch.  (Also, it would let us have one less dumb ancient bug open, whatever we do.)

Comment 7

[Stuart Morgan]

Comment on attachment 474481 [details] [diff] [review]
Hack

sr=smorgan

Sure; there seems to be no real downside here, and who knows what weird broken string we haven't run across yet ;)

Being the first line of defense is irrelevant at this point since we aren't building on trunk (and nobody cares about breaking this anyway).

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/84ca768cb983