354089 - onfocus="alert(); this.blur();" causes infinite alerts

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Calling "blur" after "alert" doesn't work; we actually refocus the element. See attached testcase and patch.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: testcase

Clicking in the input should pop up one alert and not give it focus. Instead it keeps popping up alerts ad infinitum.

What happens is that the blur() doesn't update the focus controller, so the focus controller still thinks that the element is focused. Then tearing down the alert()'s window sends a platform window activate event to the document window, and the ESM asks the focus controller which element should be focused, which returns the input, and the ESM focuses it.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

This fixes it by always calling EnsureFocusSynchronization in  nsEventStateManager::SendFocusBlur after we've determined what will really be focused. In this case the focus controller is informed there is nothing to focus.

Comment 3

[Jesse Ruderman]

Want to fix bug 304634, bug 279819, bug 112294, and/or bug 210240 while you're at it?

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Not really, no.

IMHO they should all be fixed by reimplementing JS alerts to make them modal only to the nearest chrome ancestor (i.e., tab).

Comment 5

[Mats Palmgren (inactive)]

Comment on attachment 239971 [details] [diff] [review]
fix

Seems reasonable. r+sr=mats

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in