When the vfyserv program is used with a server that requests client auth, it fails to shutdown because cert references are not freed. While investigating, I found several other problems (freeing a struct and then continuing to use it). Patch forthcoming.
Created attachment 240213 [details] [diff] [review] patch v1 Also fixed usage message.
Comment on attachment 240213 [details] [diff] [review] patch v1 This patch fixes the leak, so r+ . Nit : I think it would be better to have a single CERT_DestroyCertificate statement at the end that loop. This can be accomplished for example by either nesting the PK11_FindPrivKeyByAnyCert test within the result of the expiration date check. Just a suggestion. Your alignment in the Usage patch is wrong and should be fixed before checkin.
Attachment #240213 - Flags: superreview?(julien.pierre.bugs) → superreview+
My alignment of the usage message was deliberate. The message displays starting in column 1, and is wide. By starting it in column 1 of the source code, I am able to put each line of the message on one line of source, without going past 80 columns in the source file.
Attachment #240213 - Flags: review?(alexei.volkov.bugs) → review+
Bug 354384. Fix some (not all) of the reference leaks in vfyserv. Also, improve usage message. r=alexei,julien Checking in vfyserv.c; new revision: 1.13; previous revision: 1.12 Checking in vfyutil.c; new revision: 1.11; previous revision: 1.10 Checking in vfyserv.c; new revision: 184.108.40.206; previous revision: 220.127.116.11 Checking in vfyutil.c; new revision: 18.104.22.168; previous revision: 1.10 I need to retest to ensure that this fixes all the relevant reference leaks in vfyserv
Priority: -- → P3
Target Milestone: 3.12 → 3.11.4
marking fixed. If we find more problems, we can reopen this bug.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.