When the vfyserv program is used with a server that requests client
auth, it fails to shutdown because cert references are not freed.
While investigating, I found several other problems (freeing a struct
and then continuing to use it). Patch forthcoming.
Created attachment 240213 [details] [diff] [review]
Also fixed usage message.
Comment on attachment 240213 [details] [diff] [review]
This patch fixes the leak, so r+ .
Nit : I think it would be better to have a single CERT_DestroyCertificate statement at the end that loop. This can be accomplished for example by either nesting the PK11_FindPrivKeyByAnyCert test within the result of the expiration date check. Just a suggestion.
Your alignment in the Usage patch is wrong and should be fixed before checkin.
My alignment of the usage message was deliberate.
The message displays starting in column 1, and is wide.
By starting it in column 1 of the source code, I am able to put each line
of the message on one line of source, without going past 80 columns in
the source file.
Bug 354384. Fix some (not all) of the reference leaks in vfyserv.
Also, improve usage message. r=alexei,julien
Checking in vfyserv.c; new revision: 1.13; previous revision: 1.12
Checking in vfyutil.c; new revision: 1.11; previous revision: 1.10
Checking in vfyserv.c; new revision: 22.214.171.124; previous revision: 126.96.36.199
Checking in vfyutil.c; new revision: 188.8.131.52; previous revision: 1.10
I need to retest to ensure that this fixes all the relevant reference
leaks in vfyserv
marking fixed. If we find more problems, we can reopen this bug.