354384 - vfyserv shutdown failure when client auth requested

Status: RESOLVED FIXED

(NSS :: Tools, defect, P3)

Description

[Nelson Bolyard (seldom reads bugmail)]

When the vfyserv program is used with a server that requests client 
auth, it fails to shutdown because cert references are not freed.

While investigating, I found several other problems (freeing a struct
and then continuing to use it).  Patch forthcoming.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Attachment: patch v1

Also fixed usage message.

Comment 2

[Julien Pierre]

Comment on attachment 240213 [details] [diff] [review]
patch v1

This patch fixes the leak, so r+ .

Nit : I think it would be better to have a single CERT_DestroyCertificate statement at the end that loop. This can be accomplished for example by either nesting the PK11_FindPrivKeyByAnyCert test within the result of the expiration date check. Just a suggestion.

Your alignment in the Usage patch is wrong and should be fixed before checkin.

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

My alignment of the usage message was deliberate.
The message displays starting in column 1, and is wide.  
By starting it in column 1 of the source code, I am able to put each line
of the message on one line of source, without going past 80 columns in
the source file.

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

Bug 354384. Fix some (not all) of the reference leaks in vfyserv.
Also, improve usage message.  r=alexei,julien

Checking in vfyserv.c; new revision: 1.13; previous revision: 1.12
Checking in vfyutil.c; new revision: 1.11; previous revision: 1.10

Checking in vfyserv.c; new revision: 1.11.2.2; previous revision: 1.11.2.1
Checking in vfyutil.c; new revision: 1.10.2.1; previous revision: 1.10

I need to retest to ensure that this fixes all the relevant reference 
leaks in vfyserv

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

marking fixed.  If we find more problems, we can reopen this bug.