354388 - update cairo on trunk to 2006-09-26

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Update moz cairo to cairo trunk.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: cairo-update.patch

The full gfx patch.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: removed some chunks that shouldn't go in

Removed some patch chunks that shouldn't go in

Comment 3

[Frederic Bezies]

I am having a small drawing problem : no more borders for buttons and search box.

Is it related to this patch ?

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

I see some problems too. Scrollbar's down arrow button isn't painted at all in the Linux trunk.

Comment 5

[Kai Engert (:KaiE:)]

Your checkin introduced a build failure on my Linux Fedora Core 5 x86_64 system.

nsContentHTTPStartup.cpp
/usr/bin/ld: ../../dist/lib/libmozcairo.a(cairo-clip.o): relocation R_X86_64_PC32 against `_cairo_pixman_region_destroy' can not be used when making a shared object; recompile with -fPIC

I can make the build work again by reverting all your changes to mozilla/gfx/cairo since yesterday.

Comment 6

[Kai Engert (:KaiE:)]

I filed bug 354511 to track the build issue.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It looks like timeless landed some fixes referencing this bug:
http://tinderbox.mozilla.org/bonsai/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=mozilla%2Fgfx%2Fcairo&file=&filetype=match&who=timeless%25mozdev.org&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-09-27+14%3A00&maxdate=2006-09-27+16%3A00&cvsroot=%2Fcvsroot
to fix bustage on the Solaris compiler.  It would be good to get these changes merged upstream.

Comment 8

[Kai Engert (:KaiE:)]

Attachment: Code checked in by timeless

timeless, thanks for your check in, it fixed the problem I reported in comment 5.

I'm attaching the patch he checked in, for documentation purposes and possibly for sending that file to upstream maintainers. Who knows where to send it to?

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

the cairo mailing list: http://www.cairographics.org/lists

Comment 10

[Stuart Parmenter]

http://bugs.freedesktop.org

Comment 11

[Jonathan Watt [:jwatt]]

Attachment: post-cairo update screenshot

Ever since the cairo update my builds have been displaying very badly. Here's a screenshot.

Comment 12

[Jonathan Watt [:jwatt]]

Comment on attachment 241445 [details]
post-cairo update screenshot

My apologies. This was caused by some cairo twiddling detritus I was convinced I had removed from my trees. Turns out it reacted very badly to the merge. :-(