Some random address book tidy ups (nsAddrDatabase/nsDirectoryDataSource)

RESOLVED FIXED

Status

MailNews Core
Address Book
RESOLVED FIXED
12 years ago
10 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

({memory-footprint})

Trunk
memory-footprint

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
I've been meaning to submit these for a while - things I've found whilst coding. Patch coming up.
(Assignee)

Comment 1

12 years ago
Created attachment 240282 [details] [diff] [review]
Tidy up

The patch. Couple of notes:

- GetEnv() changes to m_mdbEnv were a couple of changes I'd missed in a previous patch.
- lxr indicates that NS_NewAbDirectoryDataSource is unused (http://lxr.mozilla.org/mozilla/search?string=NS_NewAbDirectoryDataSource)
Attachment #240282 - Flags: superreview?(bienvenu)
Attachment #240282 - Flags: review?(bienvenu)

Comment 2

12 years ago
Comment on attachment 240282 [details] [diff] [review]
Tidy up

thx for the patch, Mark.
Attachment #240282 - Flags: superreview?(bienvenu)
Attachment #240282 - Flags: superreview+
Attachment #240282 - Flags: review?(bienvenu)
Attachment #240282 - Flags: review+
(Assignee)

Comment 3

12 years ago
Patch checked in.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.