Closed
Bug 354425
Opened 19 years ago
Closed 19 years ago
Some random address book tidy ups (nsAddrDatabase/nsDirectoryDataSource)
Categories
(MailNews Core :: Address Book, defect)
MailNews Core
Address Book
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: standard8, Assigned: standard8)
Details
(Keywords: memory-footprint)
Attachments
(1 file)
|
5.26 KB,
patch
|
Bienvenu
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
I've been meaning to submit these for a while - things I've found whilst coding. Patch coming up.
|
Assignee | |
Comment 1•19 years ago
|
||
The patch. Couple of notes:
- GetEnv() changes to m_mdbEnv were a couple of changes I'd missed in a previous patch.
- lxr indicates that NS_NewAbDirectoryDataSource is unused (http://lxr.mozilla.org/mozilla/search?string=NS_NewAbDirectoryDataSource)
Attachment #240282 -
Flags: superreview?(bienvenu)
Attachment #240282 -
Flags: review?(bienvenu)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 240282 [details] [diff] [review]
Tidy up
thx for the patch, Mark.
Attachment #240282 -
Flags: superreview?(bienvenu)
Attachment #240282 -
Flags: superreview+
Attachment #240282 -
Flags: review?(bienvenu)
Attachment #240282 -
Flags: review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
Patch checked in.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Updated•17 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•