354467 - Refreshing file associations is very slow due to using SendMessageTimeout instead of SHChangeNotify

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect)

Description

[Robert Strong (they/them - no direct email)]

Found while working on Vista integration... annoyed by it too. ;)

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: use SHChangeNotify

Doug, just from counting while setting as default without this patch it took anywhere from 7 to 11 seconds and with this patch around a second.

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 240305 [details] [diff] [review]
use SHChangeNotify

The difference is that only the shell will not get the update message whereas before, every top level window got the change notification.  I think this is reasonable and anyone depending on this sort of notification probably deserves to be broken.

Can you also change the call in RestoreFileSettings() as well?  Then you can also remove the MOZ_HWND_BROADCAST_MSG_TIMEOUT define.

With that, or reasons not to, r=me.

Comment 3

[Robert Strong (they/them - no direct email)]

(In reply to comment #2)
> (From update of attachment 240305 [details] [diff] [review] [edit])
> The difference is that only the shell will not get the update message whereas
> before, every top level window got the change notification.  I think this is
> reasonable and anyone depending on this sort of notification probably deserves
> to be broken.
> 
> Can you also change the call in RestoreFileSettings() as well?  Then you can
> also remove the MOZ_HWND_BROADCAST_MSG_TIMEOUT define.
I've removed RestoreFileSettings() entirely in the Vista specific patch for setting OS defaults.

Comment 4

[Robert Strong (they/them - no direct email)]

Checked in to trunk.

Comment 5

[Robert Strong (they/them - no direct email)]

I file bug 354546 for removing the RestoreFileSettings cruft