The default bug view has changed. See this FAQ.

fipstest sha_test needs to detect SHA tests that are incorrectly configured for BIT oriented implementations

RESOLVED FIXED in 3.12

Status

NSS
Tools
--
enhancement
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Wan-Teh Chang, Assigned: Wan-Teh Chang)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

747 bytes, patch
Neil Williams
: review+
glen beasley
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
The sha_test function in the fipstest test program needs
to detect SHA tests that are incorrectly configured for
BIT oriented implementations.  NSS is a BYTE oriented
implementation.
(Assignee)

Comment 1

11 years ago
Created attachment 240364 [details] [diff] [review]
Proposed patch

The message lengths are in bits.  For a BYTE oriented
implementation, the message lengths are multiples of 8.
For a BIT oriented implementation, the message lengths
can be any integers.

So we fail with an error message (to stderr) if we see
a message length that's not a multiple of 8.
Attachment #240364 - Flags: superreview?(glen.beasley)
Attachment #240364 - Flags: review?(neil.williams)

Updated

11 years ago
Attachment #240364 - Flags: superreview?(glen.beasley) → superreview+
(Assignee)

Comment 2

11 years ago
I checked in the patch on the NSS trunk (NSS 3.12).

Checking in fipstest.c;
/cvsroot/mozilla/security/nss/cmd/fipstest/fipstest.c,v  <--  fipstest.c
new revision: 1.31; previous revision: 1.30
done
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Component: Libraries → Tools
Resolution: --- → FIXED
Target Milestone: --- → 3.12

Comment 3

11 years ago
Comment on attachment 240364 [details] [diff] [review]
Proposed patch

Shouldn't the message be "tests are incorrectly configured..."?
Attachment #240364 - Flags: review?(neil.williams) → review+
(Assignee)

Comment 4

11 years ago
Neil, I made the change you suggested.  Thanks!

Checking in fipstest.c;
/cvsroot/mozilla/security/nss/cmd/fipstest/fipstest.c,v  <--  fipstest.c
new revision: 1.32; previous revision: 1.31
done
You need to log in before you can comment on or make changes to this bug.