355026 - Category menu on Deviant Art no longer works

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Steve England [:stevee]]

1. New profile, load firefox
2. Go to http://www.deviantart.com/
3. In the upper left corner, there is a 'Category' button. Press the button

Expected:
Menu pops up under the button populated with items that can be clicked.

Actual:
Menu pops up under the button, but is empty.

Works
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1) Gecko/2006093003 BonEcho/2.0

Doesn't Work
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1) Gecko/2006100103 BonEcho/2.0

Checkins
http://tinderbox.mozilla.org/bonsai/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=MOZILLA_1_8_BRANCH&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-09-30+02%3A00%3A00&maxdate=2006-10-01+04%3A00%3A00&cvsroot=%2Fcvsroot

Requesting blocking for 2.0 since this is a recent regression.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

This is a regression from bug 354711 (tested via local backout), I'm working on a minimized testcase.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: minimal testcase

Current trunk passes, current branch fails.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Branch doesn't have bug 342062, which touches a lot of this code, so that may be related.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Commenting out the call to SetDirty() in nsContentList::PopulateSelf "fixes" this bug.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

*** Bug 355021 has been marked as a duplicate of this bug. ***

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Should I back out bug 354711 from branch?

Comment 7

[Mike Schroepfer]

(In reply to comment #6)
> Should I back out bug 354711 from branch?
> 

Yep - let's do that until we can figure out a better solution.  Backing us out at least gets us in sync with 1.5.0.7...

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

backed out bug 354711 from 1.8.1.

Comment 9

[Adam Guthrie]

Attachment: MochiKit unit test

This is Gavin's testcase converted into the MochiKit testcase format.