355080 - prettify about:config warning

Status: RESOLVED FIXED

(Camino Graveyard :: General, enhancement)

Description

[philippe (part-time)]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en; rv:1.9a1) Gecko/20061002 Camino/1.2+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en; rv:1.9a1) Gecko/20061002 Camino/1.2+

Give the 'about:config' scary warning page some Camino branding.
per bug 303193 comment #33.

Reproducible: Always

Comment 1

[philippe (part-time)]

Attachment: screenshot of proposal

Comment 2

[philippe (part-time)]

If you prefer the 'Scary Warning Title' to be coloured blue (similar to the colours in bug 303193), that is trivial to change.

I'm not sure what I've done is the 'correct' or 'best' way to handle this. Someone with more knowledge of XUL should correct me. I'll attach the modified config.css file next.

Comment 3

[philippe (part-time)]

Attachment: modified config.css

changes:
#exclam
{
  list-style-image: none; /* <-- set to none */
  margin-right: 3em;
  background: /* attached as data URI */
  width: 109px;
  height: 108px; /* matching size of image */
}

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Confirming this ;)

I think we probably want to sync with the styles from bug 303193 as closely as possible (now that those styles are final), unless someone offers a compelling reason to the contrary.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Ahem.  Clicking the right button first ;)  What was it Hicks said?  Shuffles feet and whistles?

Comment 6

[philippe (part-time)]

Attachment: screenshot, proposal 2

The 'Be Careful !' title in blue, better balancing the white-space around the alert icon.

Comment 7

[philippe (part-time)]

Attachment: screenshot, proposal 2

Ahem, correct mime-type... 
a disease :=)

Comment 8

[philippe (part-time)]

Attachment: screenshot, proposal 3

Larger type for the 'Be Careful !' warning message, some more white-space around that title.

Comment 9

[philippe (part-time)]

While playing around with the Camino-alert icon image, taken form bug , I notice that the image has some 10px white, empty space to the left. For the purpose of testing I cropped it out, but that results in some slight degradation of the image, due to recompression.

Jon, can you attach the image in png format, without that empty space ? It should be about 100px wide.

Comment 10

[Jon Hicks]

Attachment: Cropped Error Icon

Here we are. The extra whitespace was just me being lazy and not putting it into the CSS!

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

philippe, can you attach a modified config.css that does "proposal 3" (and includes the icon as data: of course)?

Comment 12

[philippe (part-time)]

Attachment: modified config.css based on proposal 3

finetuned some white-space (a pixel here, a pixel there), with Jon's image.

Comment 13

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 242021 [details]
modified config.css based on proposal 3

Whoever checks this in (as embed-replacements/skin/classic/global/config.css) should probably add philippe to the contributor list in the file's license section.

Comment 14

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 242021 [details]
modified config.css based on proposal 3

rs=pink

Comment 15

[froodian (Ian Leue)]

Checked in on 1.8branch and trunk.