355204 - Add Bookmark Sheet's "Bookmark All Tabs" Checkbox should read "Bookmark Current Tabs as Tab Group"

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[froodian (Ian Leue)]

This is a followup bug to bug 275170.  When we create the menu item for making a tab group, we should use the same language in the "Add Bookmark" sheet.   Currently, the checkbox reads "Bookmark all tabs".  To match the menu item's proposed title, this checkbox should read "Bookmark Current Tabs as Tab Group".

Comment 1

[froodian (Ian Leue)]

Attachment: new AddBookmark.nib

Just does comment 0.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 241643 [details]
new AddBookmark.nib

A minor niggle: the nib gets a bit wonky (spacing between the checkbox and the buttons) when resized down to 400, so I'd prefer the min size be fixed at 450 instead.

r=ardissone with or without that change, though.

Requesting rs from pink; we're just changing the text of the checkbox label to 1) be more descriptive and 2) be in sync with the menu items after menu cleanup.

Comment 3

[froodian (Ian Leue)]

Attachment: New AddBookmark.nib

Same as last time, but sets the minimum size to 450, per comment 2.

Comment 4

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 241740 [details]
New AddBookmark.nib

rs=pink

Comment 5

[froodian (Ian Leue)]

Checked in on 1.8branch and trunk.