Add Bookmark Sheet's "Bookmark All Tabs" Checkbox should read "Bookmark Current Tabs as Tab Group"

RESOLVED FIXED in Camino1.5

Status

Camino Graveyard
Bookmarks
--
minor
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: froodian (Ian Leue), Assigned: froodian (Ian Leue))

Tracking

({fixed1.8.1})

1.8 Branch
Camino1.5
PowerPC
Mac OS X
fixed1.8.1

Details

Attachments

(1 attachment, 1 obsolete attachment)

7.64 KB, application/zip
Mike Pinkerton (not reading bugmail)
: superreview+
Details
(Assignee)

Description

11 years ago
This is a followup bug to bug 275170.  When we create the menu item for making a tab group, we should use the same language in the "Add Bookmark" sheet.   Currently, the checkbox reads "Bookmark all tabs".  To match the menu item's proposed title, this checkbox should read "Bookmark Current Tabs as Tab Group".
(Assignee)

Comment 1

11 years ago
Created attachment 241643 [details]
new AddBookmark.nib

Just does comment 0.
Attachment #241643 - Flags: review?(alqahira)
Comment on attachment 241643 [details]
new AddBookmark.nib

A minor niggle: the nib gets a bit wonky (spacing between the checkbox and the buttons) when resized down to 400, so I'd prefer the min size be fixed at 450 instead.

r=ardissone with or without that change, though.

Requesting rs from pink; we're just changing the text of the checkbox label to 1) be more descriptive and 2) be in sync with the menu items after menu cleanup.
Attachment #241643 - Flags: superreview?(mikepinkerton)
Attachment #241643 - Flags: review?(alqahira)
Attachment #241643 - Flags: review+
(Assignee)

Comment 3

11 years ago
Created attachment 241740 [details]
New AddBookmark.nib

Same as last time, but sets the minimum size to 450, per comment 2.
Attachment #241643 - Attachment is obsolete: true
Attachment #241740 - Flags: superreview?(mikepinkerton)
Attachment #241643 - Flags: superreview?(mikepinkerton)
Comment on attachment 241740 [details]
New AddBookmark.nib

rs=pink
Attachment #241740 - Flags: superreview?(mikepinkerton) → superreview+
(Assignee)

Comment 5

11 years ago
Checked in on 1.8branch and trunk.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.