355208 - Range leaves artifacts

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[aaronr]

Assume you have a default range and an incremental range bound to the same node.  Set the value of the default range to a new value.  Click on the incremental range to set a third different value.  There will be an artifact left on the incremental range.

The problem is that when the focus changes from the non-incremental to incremental range due to the mouse click, the bound node will get the value of the non-incremental range.  The incremental change will then get the value of the bound node.  When the mouse down event is handled, the slider is erased from the position of prevX.  However, prevX will reflect the INITIAL value of the incremental slider, not the current value, so we are erasing a slider that doesn't exist and we leave around the current slider.

Comment 1

[aaronr]

Attachment: testcase

Comment 2

[aaronr]

Attachment: patch 1

fixed this by setting prevX to null on mouseup and upon initialization.  And at mousedown when prevX isn't set, then I initialize it to the x position that corresponds to the current slider value.

Comment 3

[alexander :surkov (:asurkov)]

Looks right, do you need in "dump" calls and should you null prevX on 'mouseup' event (I doubt since 'handler' object is recreated for every 'mousedown' event)? Today later I'll look more precisely.

Comment 4

[aaronr]

Attachment: patch 2

Sorry, I should have made sure that I had all of the dumps out of there.  You are also right in that we don't need to set it to null on mouseup.

Comment 5

[aaronr]

checked into trunk

Comment 6

[aaronr]

checked into 1.8.0 branch on 2006/10/11

Comment 7

[aaronr]

checked into 1.8 branch on 2006/11/21