355226 - Add Support for Attendees to the Google Calendar Provider

Status: RESOLVED FIXED

(Calendar :: Provider: GData, enhancement)

Description

[Philipp Kewisch [:Fallen][📱📆]]

This Bug describes adding Attendee Support. A patch will follow once bug 35517 has been discussed, due to a whitespace issue.

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Attendee support - v1

I decided to postpone full invitations support until we have a non-wcap-specific interface for invitations. This patch adds support for reading and writing attendees.

I haven't found out how to delete attendees in the new event dialog, at least the last attendee is not removable by deleting the text and clicking ok.

Comment 2

[Daniel Boelzle [:dbo]]

Comment on attachment 277360 [details] [diff] [review]
Attendee support - v1

>+    if (aItem.organizer) {
>+        // XXX Organizer should be in the attendee list, see Bug 354559. For
>+        // now, work around it.
>+        attendees.push(aItem.organizer);
>+    }
I disagree with auto inclusion of the organizer, please see my comment <https://bugzilla.mozilla.org/show_bug.cgi?id=354559#c3>.

>+    if ((a.organizer && !b.organizer) ||
>+        (!a.organizer && b.organizer) ||
>+        (a.organizer && b.organizer && a.organizer.id != b.organizer.id)) {
>+        return false;
>+    }
This puts more stress on finally fixing calAttendee's attribute id setter to normalize the set id (case MaILtO: etc). IIRC mickey already works around that problem at least once.

>+            attendee.rsvp =
>+                getPrefSafe("calendar.google.sendEventNotifications", 
If you can't map/save the RSVP expectation, then IMO just leave it FALSE (default).

r=dbo

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

(In reply to comment #2)
> I disagree with auto inclusion of the organizer, please see my comment
> <https://bugzilla.mozilla.org/show_bug.cgi?id=354559#c3>.
Ok, changed comments accordingly.

> This puts more stress on finally fixing calAttendee's attribute id setter to
> normalize the set id (case MaILtO: etc). IIRC mickey already works around that
> problem at least once.
I'll leave this to the bug to fix that setter. The worst thing that can happen is that we have extra net load.
("calendar.google.sendEventNotifications", 
> If you can't map/save the RSVP expectation, then IMO just leave it FALSE
> (default).
Fixed



Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED

This will be available with version 0.3 of the Provider for Google Calendar

Comment 4

[Daniel Boelzle [:dbo]]

(In reply to comment #3)
> > This puts more stress on finally fixing calAttendee's attribute id setter to
> > normalize the set id (case MaILtO: etc). IIRC mickey already works around that
> > problem at least once.
> I'll leave this to the bug to fix that setter. The worst thing that can happen
> is that we have extra net load.
which bug?

Comment 5

[Raymond]

Since a few days I have a Problem with the google calendar sync with lightning.
My calendar items on google calendar won't show up in lightning ( they do exist on google )

When I create a new item I get an error in the error console: 

Error: aItem.calendar has no properties
Source File: chrome://calendar/content/calendar-item-editing.js
Line: 362

This is in the function: checkForAttendees(aItem, aOriginalItem) 
so I think it has to do with this bug..
not sure if the not showing up in lightning is also related to this.

I'm using:
thunderbird 2.0.0.6 ( on windows xp )
lightning 2007082106
provider for google calendar 0.2.1

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

Version 0.2.1 does not have support for attendees, so I doubt it has to do with this. Please either try a gdata cvs build or file a new bug.

Comment 7

[klint]

Wouldn't Raymond's problem be a new occurrence of bug 392627, by any chance ?

Comment 8

[Raymond]

I think the problem of the items not showing up is an occurrence of bug 392627.

I will try to get a newer version of the provider from cvs (version 0.2.2) and see if the problems above are still there.

If they are, I will file a new bug.