NSIS installer removes folders but not files listed in removed-files.in

VERIFIED FIXED in mozilla1.8.1

Status

()

Toolkit
NSIS Installer
VERIFIED FIXED
12 years ago
12 years ago

People

(Reporter: Stefan Sitter, Assigned: rstrong)

Tracking

({verified1.8.1})

Trunk
mozilla1.8.1
x86
Windows 2000
verified1.8.1
Points:
---
Bug Flags:
blocking-firefox2 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

12 years ago
NSIS installer removes folders but not files listed in removed-files.in

While investigating Bug 355225 I noticed that files listed in removed-files.in were not removed during installation.

The removed-files.log inside the installer package contained:
  [...]
  Dir: \defaults\profile\US\
  File: components\calAlarmService.js
  [...]

The directory was removed properly. After changing all lines starting with 'File: xyz' to 'File: \xyz' and running the installer the files were removed as expected.

After changing
toolkit/mozapps/installer/windows/nsis/make-installremoves.pl line 54
from |print "File: $file\n";| to |print "File: \\$file\n";| this works right after build.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20061002 Sunbird/0.3
(Reporter)

Updated

12 years ago
Blocks: 355225
No longer blocks: 353944
Created attachment 241101 [details] [diff] [review]
patch - prepend \ for files
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #241101 - Flags: first-review?(sspitzer)

Comment 2

12 years ago
Robert, did you attach the right patch?
Created attachment 241104 [details] [diff] [review]
correct patch

Thanks ispiked
Attachment #241101 - Attachment is obsolete: true
Attachment #241104 - Flags: first-review?
Attachment #241101 - Flags: first-review?(sspitzer)
Attachment #241104 - Flags: first-review? → first-review?(sspitzer)
Comment on attachment 241104 [details] [diff] [review]
correct patch

r=sspitzer
Attachment #241104 - Flags: first-review?(sspitzer) → first-review+
Checked in to trunk
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Comment on attachment 241104 [details] [diff] [review]
correct patch

Drivers, simple fix so we remove files that need to be removed on install
Attachment #241104 - Flags: approval1.8.1?
Comment on attachment 241104 [details] [diff] [review]
correct patch

We're done taking patches for 1.8.1 for anything less than a showstopper. If you believe that this *is* a showstopping bug, please nominate for blocking along with rationale.

Otherwise nominate for blocking 1.8.1.1 or 1.9 (or both!)
Attachment #241104 - Flags: approval1.8.1? → approval1.8.1-
*crosses fingers that a similar problem as described in comment #0 doesn't affect Firefox 2.0*
Attachment #241104 - Flags: approval1.8.1.1?
Flags: blocking1.9?
Flags: blocking1.8.1.1?
Flags: blocking1.9?
Comment on attachment 241104 [details] [diff] [review]
correct patch

Re-requesting approval.
Attachment #241104 - Flags: approval1.8.1- → approval1.8.1?
Flags: blocking-firefox2?
Blocking for RC3. Rob, can you tell us if you feel that this patch is safe for 1.8.1 branch, and what testing scenarios QA should be using to check for regressions? We'd like to be code frozen Nov 10 at midnight PDT, so the earlier we get it in nightlies and tested the better.
Flags: blocking-firefox2? → blocking-firefox2+
This should be very safe for RC3. All it does is enable removing the files as specified in the removed-files file which is already being used by Software Update when it applies an update. I'll attach a file that lists the files that should be removed for QA. We don't have a known issue as was seen by Sunbird in comment #0 which would make this easier to QA.
Created attachment 241669 [details]
removed files log for QA

Contains a list of the files that should be removed. This won't be important in the case of a clean install but it could be very important in the case of an upgrade where the previous version had these files in the installation directory.

Comment 13

12 years ago
Comment on attachment 241104 [details] [diff] [review]
correct patch

Approved for RC3.
Attachment #241104 - Flags: approval1.8.1? → approval1.8.1+
Attachment #241104 - Flags: approval1.8.1.1?
Checked in to MOZILLA_1_8_BRANCH
Keywords: fixed1.8.1
Flags: blocking1.8.1.1?
Target Milestone: --- → mozilla1.8.1
Verified Fixed with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0 (RC3)
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1 → verified1.8.1
You need to log in before you can comment on or make changes to this bug.