355242 - NSIS installer removes folders but not files listed in removed-files.in

Status: VERIFIED FIXED

(Firefox :: Installer, defect)

Description

[Stefan Sitter [:ssitter]]

NSIS installer removes folders but not files listed in removed-files.in

While investigating Bug 355225 I noticed that files listed in removed-files.in were not removed during installation.

The removed-files.log inside the installer package contained:
  [...]
  Dir: \defaults\profile\US\
  File: components\calAlarmService.js
  [...]

The directory was removed properly. After changing all lines starting with 'File: xyz' to 'File: \xyz' and running the installer the files were removed as expected.

After changing
toolkit/mozapps/installer/windows/nsis/make-installremoves.pl line 54
from |print "File: $file\n";| to |print "File: \\$file\n";| this works right after build.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20061002 Sunbird/0.3

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch - prepend \ for files

Comment 2

[Adam Guthrie]

Robert, did you attach the right patch?

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: correct patch

Thanks ispiked

Comment 4

[(not reading, please use [e-mail] instead)]

Comment on attachment 241104 [details] [diff] [review]
correct patch

r=sspitzer

Comment 5

[Robert Strong (they/them - no direct email)]

Checked in to trunk

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 241104 [details] [diff] [review]
correct patch

Drivers, simple fix so we remove files that need to be removed on install

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 241104 [details] [diff] [review]
correct patch

We're done taking patches for 1.8.1 for anything less than a showstopper. If you believe that this *is* a showstopping bug, please nominate for blocking along with rationale.

Otherwise nominate for blocking 1.8.1.1 or 1.9 (or both!)

Comment 8

[Robert Strong (they/them - no direct email)]

*crosses fingers that a similar problem as described in comment #0 doesn't affect Firefox 2.0*

Comment 9

[Reed Loden [:reed]]

Comment on attachment 241104 [details] [diff] [review]
correct patch

Re-requesting approval.

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Blocking for RC3. Rob, can you tell us if you feel that this patch is safe for 1.8.1 branch, and what testing scenarios QA should be using to check for regressions? We'd like to be code frozen Nov 10 at midnight PDT, so the earlier we get it in nightlies and tested the better.

Comment 11

[Robert Strong (they/them - no direct email)]

This should be very safe for RC3. All it does is enable removing the files as specified in the removed-files file which is already being used by Software Update when it applies an update. I'll attach a file that lists the files that should be removed for QA. We don't have a known issue as was seen by Sunbird in comment #0 which would make this easier to QA.

Comment 12

[Robert Strong (they/them - no direct email)]

Attachment: removed files log for QA

Contains a list of the files that should be removed. This won't be important in the case of a clean install but it could be very important in the case of an upgrade where the previous version had these files in the installation directory.

Comment 13

[Mike Schroepfer]

Comment on attachment 241104 [details] [diff] [review]
correct patch

Approved for RC3.

Comment 14

[Robert Strong (they/them - no direct email)]

Checked in to MOZILLA_1_8_BRANCH

Comment 15

[Carsten Book [:Tomcat]]

Verified Fixed with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0 (RC3)