355336 - TB1507 topcrash [@ nsAddrDatabase::GetRowFromAttribute]

Status: RESOLVED DUPLICATE of bug 165296

(MailNews Core :: Address Book, defect)

Description

[Adam Guthrie]

I have a feeling that bug 165296 fixed this on branch and trunk, but that patch might be too big to go in to a 1.8.0.x release.

Maybe it's possible that we could add the same sort of error checking to this function that the patch in that bug added to prevent the crash?

Incident ID: 24103579
Stack Signature	nsAddrDatabase::GetRowFromAttribute 61662485
Product ID	Thunderbird15
Build ID	2006090918
Trigger Time	2006-10-03 20:30:36.0
Platform	Win32
Operating System	Windows NT 5.1 build 2600
Module	thunderbird.exe + (0048690a)
URL visited	
User Comments	
Since Last Crash	10 sec
Total Uptime	328 sec
Trigger Reason	Access violation
Source File, Line No.	c:/builds/tinderbox/Tb-Mozilla1.8.0-Release/WINNT_5.2_Depend/mozilla/mailnews/addrbook/src/nsAddrDatabase.cpp, line 3618
Stack Trace 	
nsAddrDatabase::GetRowFromAttribute  [mozilla/mailnews/addrbook/src/nsAddrDatabase.cpp, line 3618]
nsAddrDatabase::GetCardFromAttribute  [mozilla/mailnews/addrbook/src/nsAddrDatabase.cpp, line 3635]
nsAbAddressCollecter::GetCardFromAttribute  [mozilla/mailnews/addrbook/src/nsAbAddressCollecter.cpp, line 95]
nsAbAddressCollecter::CollectAddress  [mozilla/mailnews/addrbook/src/nsAbAddressCollecter.cpp, line 133]
nsAbAddressCollecter::CollectUnicodeAddress  [mozilla/mailnews/addrbook/src/nsAbAddressCollecter.cpp, line 84]
XPTC_InvokeByIndex  [mozilla/xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp, line 102]
XPCWrappedNative::CallMethod  [mozilla/js/src/xpconnect/src/xpcwrappednative.cpp, line 2156]
XPC_WN_CallMethod  [mozilla/js/src/xpconnect/src/xpcwrappednativejsops.cpp, line 1445]
js_Invoke  [mozilla/js/src/jsinterp.c, line 1187]
js_Interpret  [mozilla/js/src/jsinterp.c, line 3584]
js_Execute  [mozilla/js/src/jsinterp.c, line 1434]
JS_EvaluateUCScriptForPrincipals  [mozilla/js/src/jsapi.c, line 4131]
nsJSContext::EvaluateString  [mozilla/dom/src/base/nsJSEnvironment.cpp, line 1063]
nsGlobalWindow::RunTimeout  [mozilla/dom/src/base/nsGlobalWindow.cpp, line 6381]
nsGlobalWindow::TimerCallback  [mozilla/dom/src/base/nsGlobalWindow.cpp, line 6758]
nsAppStartup::Run  [mozilla/toolkit/components/startup/src/nsAppStartup.cpp, line 151]
main  [mozilla/mail/app/nsMailApp.cpp, line 62]
kernel32.dll + 0x362b6 (0x77e962b6)

Comment 1

[Mark Banner (:standard8)]

(In reply to comment #0)
> I have a feeling that bug 165296 fixed this on branch and trunk, but that patch
> might be too big to go in to a 1.8.0.x release.

Most of it is whitespace differences.

> Maybe it's possible that we could add the same sort of error checking to this
> function that the patch in that bug added to prevent the crash?

You need the whole patch to make sure its fixed.

If the patch applies on the 1.8.0.x branch then I'll be happy to nominate it given that there seems to be no reoccurance on trunk, and branch reoccurances have at least stopped for the time being.

However, let's deal with that in bug 165296 rather than a separate bug as its all the same issue.

Comment 2

[Mark Banner (:standard8)]

The 1.8 branch patch in bug 165296 also applies cleanly to the 1.8.0.x branch. Therefore I'll build and test it for a couple of days, but the request will go onto bug 165296 so I'll close this one as a duplicate of that.

*** This bug has been marked as a duplicate of 165296 ***

Comment 3

[Adam Guthrie]

Great, thanks.