Closed
Bug 355354
Opened 19 years ago
Closed 19 years ago
[Mac] native-styling for html content should be enabled only in Camino builds
Categories
(Core :: Layout: Form Controls, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: asaf, Assigned: asaf)
Details
(Keywords: regression)
Attachments
(1 file)
|
2.76 KB,
patch
|
jaas
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
For HTML content, nsINativeThemeCocoa and the relevant style rules in forms.css are not ready for prime time for anything but Camino.
|
Assignee | |
Updated•19 years ago
|
Status: NEW → ASSIGNED
Flags: blocking1.9?
|
|
Assignee | |
Updated•19 years ago
|
Priority: -- → P1
|
|
Assignee | |
Comment 1•19 years ago
|
||
note nsNativeThemeMac is still used for cocoa, cairo-disabled builds.
Attachment #241157 -
Flags: superreview?(dbaron)
Attachment #241157 -
Flags: review?(joshmoz)
Comment on attachment 241157 [details] [diff] [review]
patch
I think we're not supposed to have app-specific macro tests in this code, however we already do it twice for context menu hacks. I need to clean that up at some point and I'll take care of this too when I do that.
Attachment #241157 -
Flags: review?(joshmoz) → review+
Attachment #241157 -
Flags: superreview?(dbaron) → superreview+
|
|
Assignee | |
Comment 3•19 years ago
|
||
mozilla/layout/style/forms.css 3.120
mozilla/widget/src/cocoa/nsNativeThemeCocoa.cpp 1.3
mozilla/widget/src/mac/nsNativeThemeMac.cpp 1.55
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•19 years ago
|
Flags: blocking1.9?
|
|
Assignee | |
Updated•19 years ago
|
Whiteboard: [19a1]
|
|
Assignee | |
Updated•19 years ago
|
Whiteboard: [19a1]
You need to log in
before you can comment on or make changes to this bug.
Description
•