355360 - #unifinder-search-results-listbox min-height property is too small

Status: VERIFIED FIXED

(Calendar :: Sunbird Only, defect)

Description

[dror3go]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1) Gecko/20060918 Firefox/2.0
Build Identifier: 

In order to avoid a cosmetic bug - #unifinder-search-results-listbox should have a min-height, So that the scrollbars wouldn't show on top of the tree.

Reproducible: Always

Comment 1

[dror3go]

Attachment: example

Comment 2

[Martin Schröder [:mschroeder]]

*** Bug 355359 has been marked as a duplicate of this bug. ***

Comment 3

[Sven Giermann]

There already is a min-height set, but you are right: the value of "40" is still too small.
I recently added Unifinder into Lightning and changed the min-height as well.

Just go to into "classic.jar" and change the file "calendar.css" to increase the value to 58 which worked for me in Windows platform (If you have enough time, you could also create a patch and ask for ui-review...):


/*--------------------------------------------------------------------
 * Unifinder
 *-------------------------------------------------------------------*/
/* workaround to avoid Window Flick */
#unifinder-search-results-listbox
{
   /* SG, 20.02.2007 - increased to display scrollbar and at least 2 lines */
   min-height : 58px ;
}

Comment 4

[Simon Paquet [:sipaq]]

-> Morphing bug and assigning it to me

Comment 5

[Simon Paquet [:sipaq]]

Attachment: Patch v1

Patch to show at least 3 lines in the unifinder. I will attach a screenshot for UI review. Matthew, can you please check, whether this looks ok on OS X, since I can only test this on Windows XP.

Comment 6

[Simon Paquet [:sipaq]]

Attachment: Screenshot for UI review (patch v1)

Comment 7

[Matthew (lilmatt) Willis]

Attachment: Mac screenshot with patch

Comment 8

[Matthew (lilmatt) Willis]

Comment on attachment 259474 [details]
Mac screenshot with patch

This is as small as it you can make the unifinder before it collapses on Mac, using this patch.

Comment 9

[Matthew (lilmatt) Willis]

Comment on attachment 258957 [details] [diff] [review]
Patch v1

You want to show 4 lines on Mac, since otherwise the scrollbar is drawn goofy.
92px is a good value IMHO.  I'll attach a screenshot of that.  r=lilmatt with that fixed.

Comment 10

[Matthew (lilmatt) Willis]

Attachment: Mac screenshot with 92px (4 lines)

Comment 11

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 258957 [details] [diff] [review]
Patch v1

ui-review=mvl with the 4 lines as proposed by matt.

Comment 12

[Matthew (lilmatt) Willis]

Patch with the Mac change checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED

Comment 13

[Omar Bajraszewski]

Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.4pre) Gecko/20070325 Calendar/0.5pre

Comment 14

[Martin Schröder [:mschroeder]]

VERIFIED per comment#13