355658 - e4x/Statements/12.2.js, result: FAILED browser|shell

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bob Clary [:bc] (inactive)]

trunk window/linux failed 20061005, passed 20061004

STATUS: 12.2 - For-in statement

FAILED!: Section 1.0 of test -
FAILED!: Type mismatch, expected type string, actual type number
FAILED!:
FAILED!: Section 1.1 of test -
FAILED!: Type mismatch, expected type string, actual type number
FAILED!:
1.count PASSED
FAILED!: Section 2.0 of test -
FAILED!: Type mismatch, expected type string, actual type number
FAILED!:
FAILED!: Section 2.1 of test -
FAILED!: Type mismatch, expected type string, actual type number
FAILED!:
2.count PASSED
FAILED!: Section 3.0 of test -
FAILED!: Type mismatch, expected type string, actual type number
FAILED!:
FAILED!: Section 3.1 of test -
FAILED!: Type mismatch, expected type string, actual type number
FAILED!:
3.count PASSED

Comment 1

[Brendan Eich [:brendan]]

Regression from bug 354982 I think.

/be

Comment 2

[Igor Bukanov]

(In reply to comment #1)
> Regression from bug 354982 I think.

Right, XML was treated too specially. Patch in a minute.

Comment 3

[Igor Bukanov]

Attachment: Fix v1

Even lesser code: the patch uses the common code converting id to string for both XML and non-XML cases.

Comment 4

[Igor Bukanov]

Attachment: diff -w version of Fix v1

Comment 5

[Igor Bukanov]

Attachment: diff -w version of Fix v1 for real

The previous patch was without -w

Comment 6

[Igor Bukanov]

Nominating for JS1.7/1.8.1.1

Comment 7

[Brendan Eich [:brendan]]

Comment on attachment 241439 [details] [diff] [review]
Fix v1

Looks good, needed on trunk ASAP, and for js1.7src/1.8.1.1 as nominated.

/be

Comment 8

[Igor Bukanov]

I committed the patch from comment 3 to the trunk:

Checking in jsiter.c;
/cvsroot/mozilla/js/src/jsiter.c,v  <--  jsiter.c
new revision: 3.54; previous revision: 3.53
done

Comment 9

[Bob Clary [:bc] (inactive)]

verfied fixed 1.9 20061007 windows/linux

Comment 10

[Daniel Veditz [:dveditz]]

Comment on attachment 241439 [details] [diff] [review]
Fix v1

approved for 1.8 branch, a=dveditz for drivers

Comment 11

[Igor Bukanov]

Comment on attachment 241439 [details] [diff] [review]
Fix v1

This patch fixed a regression introduced by the patch for bug 354982. The patch there for 1.8.1 which is not yet approved incorporates the fix.

Comment 12

[Reed Loden [:reed]]

Patch in bug 354982 has been approved and checked-in. --> fixed1.8.1.1

Comment 13

[Bob Clary [:bc] (inactive)]

verified fixed 20061125 1.8.1.1 windows/linux/mac*