355813 - nsIWebDAVService.getResourceProperties is broken

Status: RESOLVED FIXED

(Calendar :: Provider: ICS/WebDAV, defect)

Description

[Bruno Browning]

nsIWebDAVService.getResourceProperties fails to return requested properties. This is actually rather difficult to demonstrate with current Sunbird/Lightning code since getResourceProperties is hardly used at all; will post testcase. Since no one has noticed this for months it's not a show-stopper for 0.3, but getResourceProperties will be necessary for things like CalDAV etags, detection of remote calendar types and principals, etc, in future releases.

Comment 1

[Bruno Browning]

Attachment: use getResourceProperties

This is not a proposed patch, just an attempt to demonstrate the problem with getResourceProperties. It causes the ICS provider to attempt to collect, after PUT, an item's etag using getResourceProperties, even on trunk, and to dump() a string when entering onOperationDetail.

Apply the patch, PUT an item to an ICS calendar on a WebDAV server, and note that no dump() occurs. Thrilling, I know. nsOperationStreamListener is failing to parse the 207, and thus not calling onOperationDetail.

Comment 2

[Bruno Browning]

Attachment: use GetElementsByTagNameNS

Same problem, same solution as bug 337790

Comment 3

[cmtalbert]

Comment on attachment 241522 [details] [diff] [review]
use GetElementsByTagNameNS

Sorry it took so long to get to this. It slipped past in the bugmail. This patch looks good. My only nit is that there is an extra space after ("DAV:"),
r+ with that nit

Comment 4

[Bruno Browning]

Attachment: address r1 nit

de-nitted

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 243104 [details] [diff] [review]
address r1 nit

r=mvl

Comment 6

[Matthew (lilmatt) Willis]

Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED