Closed
Bug 355841
Opened 18 years ago
Closed 18 years ago
Bug::check_can_change_field() incorrectly updates $PrivilegesRequired
Categories
(Bugzilla :: Creating/Changing Bugs, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.0
People
(Reporter: LpSolit, Assigned: LpSolit)
References
Details
(Keywords: regression)
Attachments
(1 file)
1.60 KB,
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
Now that we moved CheckCanChangeField() from process_bug.cgi to Bug.pm, $PrivilegesRequired is passed by reference instead of as a scalar. But I forgot to fix the routine accordingly, and so wrong error messages are thrown as process_bug.cgi gets the wrong level value.
Assignee | ||
Comment 1•18 years ago
|
||
Attachment #241541 -
Flags: review?(mkanat)
Comment 2•18 years ago
|
||
Comment on attachment 241541 [details] [diff] [review]
patch, v1
Looks right to me!
Attachment #241541 -
Flags: review?(mkanat) → review+
Updated•18 years ago
|
Status: NEW → ASSIGNED
Flags: blocking3.0+
Flags: approval?
Updated•18 years ago
|
Flags: approval? → approval+
Assignee | ||
Comment 3•18 years ago
|
||
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v <-- Bug.pm
new revision: 1.159; previous revision: 1.158
done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•