Open file dialog doesn't allow me to open XUL documents

RESOLVED FIXED

Status

()

Product:
Core
Component:
Widget: Cocoa
Status:
RESOLVED FIXED
Reported:
13 years ago
Modified:
13 years ago

People

(Reporter: hwaara, Assigned: hwaara)

Tracking

({regression})

Version:
Trunk
Platform:
PowerPC
macOS
Keywords:
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Fix v2
4.17 KB, patch
jaas
: review+
mikepinkerton
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

•
13 years ago 
Tested in today's trunk (20061008), where it's broken, whereas it worked in 20060925 (pre-Cocoa widgets).

Steps to reproduce:

1. Choose File > Open...
2. Try to choose a XUL file

Result:

It's greyed out, you can't choose them.

Since drag and drop is also not working, there's no way AFAICS to open XUL files right now. :/
(Assignee)

Comment 1

•
13 years ago 
Created attachment 241596 [details] [diff] [review]
Fix v1

Here's a fix. Make cocoa respect the "*" filter, which means "all files".
Attachment #241596 - Flags: review?(joshmoz)

Comment 2

•
13 years ago 
Comment on attachment 241596 [details] [diff] [review]
Fix v1

You're leaking giantFilterString when you return early.
Attachment #241596 - Flags: review?(joshmoz) → review-
(Assignee)

Comment 3

•
13 years ago 
Created attachment 241861 [details] [diff] [review]
Fix v2

Thanks for catching that, Josh. Here's a patch which autoreleases that, to avoid the issue.
Assignee: joshmoz → hwaara
Attachment #241596 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #241861 - Flags: review?(joshmoz)

Updated

•
13 years ago
Attachment #241861 - Flags: review?(joshmoz) → review+

Updated

•
13 years ago
Attachment #241861 - Flags: superreview?(mikepinkerton)
 (Assignee)

Comment 4

•
13 years ago 
Comment on attachment 241861 [details] [diff] [review]
Fix v2

Checked in before I saw the sr-request (sorry!), but Josh says it's fine.
Attachment #241861 - Flags: superreview?(mikepinkerton)
 (Assignee)

Comment 5

•
13 years ago 
Fixed on trunk
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED

Comment 6

•
13 years ago 
Comment on attachment 241861 [details] [diff] [review]
Fix v2

sr=pink
Attachment #241861 - Flags: superreview?
Attachment #241861 - Flags: superreview? → superreview+
You need to log in before you can comment on or make changes to this bug.