Closed
Bug 355894
Opened 19 years ago
Closed 19 years ago
Open file dialog doesn't allow me to open XUL documents
Categories
(Core :: Widget: Cocoa, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: hwaara, Assigned: hwaara)
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
|
4.17 KB,
patch
|
jaas
:
review+
mikepinkerton
:
superreview+
|
Details | Diff | Splinter Review |
Tested in today's trunk (20061008), where it's broken, whereas it worked in 20060925 (pre-Cocoa widgets).
Steps to reproduce:
1. Choose File > Open...
2. Try to choose a XUL file
Result:
It's greyed out, you can't choose them.
Since drag and drop is also not working, there's no way AFAICS to open XUL files right now. :/
|
Assignee | |
Comment 1•19 years ago
|
||
Here's a fix. Make cocoa respect the "*" filter, which means "all files".
Attachment #241596 -
Flags: review?(joshmoz)
Comment on attachment 241596 [details] [diff] [review]
Fix v1
You're leaking giantFilterString when you return early.
Attachment #241596 -
Flags: review?(joshmoz) → review-
|
|
Assignee | |
Comment 3•19 years ago
|
||
Thanks for catching that, Josh. Here's a patch which autoreleases that, to avoid the issue.
Assignee: joshmoz → hwaara
Attachment #241596 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #241861 -
Flags: review?(joshmoz)
Attachment #241861 -
Flags: review?(joshmoz) → review+
Attachment #241861 -
Flags: superreview?(mikepinkerton)
|
|
Assignee | |
Comment 4•19 years ago
|
||
Comment on attachment 241861 [details] [diff] [review]
Fix v2
Checked in before I saw the sr-request (sorry!), but Josh says it's fine.
Attachment #241861 -
Flags: superreview?(mikepinkerton)
|
|
Assignee | |
Comment 5•19 years ago
|
||
Fixed on trunk
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
|
||
Comment 6•19 years ago
|
||
Comment on attachment 241861 [details] [diff] [review]
Fix v2
sr=pink
Attachment #241861 -
Flags: superreview?
|
|
||
Updated•19 years ago
|
Attachment #241861 -
Flags: superreview? → superreview+
You need to log in
before you can comment on or make changes to this bug.
Description
•