Closed Bug 355927 Opened 16 years ago Closed 13 years ago

Make description in install.rdf localizable


(Calendar :: Lightning Only, defect)

Not set


(Not tracked)



(Reporter: thorsten.fritz, Assigned: dbo)




(1 file, 1 obsolete file)

Make description in install.rdf localizale. See for details.
Attached patch v1 (obsolete) — Splinter Review
First version.
Attachment #242165 - Flags: second-review?(dmose)
Attachment #242165 - Flags: first-review?(lilmatt)
Comment on attachment 242165 [details] [diff] [review]

>Index: locales/en-US/chrome/lightning/
>+# Localized description
>+extensions.{e2fda1a4-762b-4020-b5ad-a41df1933103}.description=An integrated calendar for Thunderbird (build @BUILD_ID@)

So how are we find/replacing @BUILD_ID@ now that this is in the .properties file?
What if we move the build id into the name like
 <em:name>Lightning (build @BUILD_ID@)</em:name> ?
As Lightning 0.3.1 will be a multilanguage extension, i would like to have this bug fixed for 0.3.1.

Nominating this for blocking 0.3.1.
Flags: blocking-calendar0.3.1?
Since we're going to have to mess around with Makefiles in order to move or substitute in the build ID, we won't take this for 0.3.1.

0.5 is still a possibility however.
Flags: blocking-calendar0.3.1? → blocking-calendar0.3.1-
Comment on attachment 242165 [details] [diff] [review]

Removing myself from review request, as I'm no longer doing calendar work.  Note that one-review should soon be enough, so there's no need to re-add a second reviewer, I think.
Attachment #242165 - Flags: second-review?(dmose)
Can you provide a new patch with the necessary values find-and-replaced from the Makefile?
Not going to make the 0.5 train.
Target Milestone: Lightning 0.5 → ---
Attachment #242165 - Flags: first-review?(lilmatt) → review?(lilmatt)
Comment on attachment 242165 [details] [diff] [review]

Minusing based on comment #7.
Attachment #242165 - Flags: review?(lilmatt) → review-
What's the status here? Locales count is growing with each released version, this really should be fixed.
Thorsten, do you plan to post an updated patch?
Assignee: chef → nobody
Flags: wanted-calendar1.0+
Attached patch patch - v1Splinter Review
This patch localizes lightning's addon info, removes the build id.
I've played around with moving the build id into the version, sticking to the schema, e.g. 1.0.0pre.20081131 but this looked quite odd to me. Moreover a micro version is quite uncommon. Thinking further about it, I dropped the build id, because it's foremost only used by nightly testers which could use Thunderbird's build id once lightning is integrated.
Moreover the patch fixes calendar-timezones' thunderbird dependency
Assignee: nobody → daniel.boelzle
Attachment #348560 - Flags: review?(philipp)
Blocks: 406579
What about approach introduced with Gecko 1.9?

It's more robust than previous one, f.e. it allows to see localized description when ext. is disabled.
Attachment #348560 - Flags: review?(philipp) → review+
Comment on attachment 348560 [details] [diff] [review]
patch - v1

I'll r+ this patch, but I'd consider the gecko 1.9 way of doing things.

I've played with the install.rdf stuff before and found it to be a build config nightmare, especially when trying to create multi-lang xpi's.

I guess thats a non-issue since ause is getting rid of that code.
(In reply to comment #14)
> I've played with the install.rdf stuff before and found it to be a build config
> nightmare, especially when trying to create multi-lang xpi's.

Thanks for the pointer, but I think unless there is reasonable build scripting for multi-l10n, I'll stick to the old scheme. I don't see anyone using the new stuff on mozilla-central: <>

Pushed to comm-central <>

Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
Attachment #242165 - Attachment is obsolete: true
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.