355927 - Make description in install.rdf localizable

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Thorsten 'nightrat' Fritz]

Make description in install.rdf localizale. See http://developer.mozilla.org/en/docs/Localizing_extension_descriptions for details.

Comment 1

[Thorsten 'nightrat' Fritz]

Attachment: v1

First version.

Comment 2

[Matthew (lilmatt) Willis]

Comment on attachment 242165 [details] [diff] [review]
v1

>Index: locales/en-US/chrome/lightning/lightning.properties
>===================================================================
>+# Localized description
>+extensions.{e2fda1a4-762b-4020-b5ad-a41df1933103}.description=An integrated calendar for Thunderbird (build @BUILD_ID@)

So how are we find/replacing @BUILD_ID@ now that this is in the .properties file?

Comment 3

[Thorsten 'nightrat' Fritz]

What if we move the build id into the name like
 <em:name>Lightning (build @BUILD_ID@)</em:name> ?

Comment 4

[Thorsten 'nightrat' Fritz]

As Lightning 0.3.1 will be a multilanguage extension, i would like to have this bug fixed for 0.3.1.

Nominating this for blocking 0.3.1.

Comment 5

[Matthew (lilmatt) Willis]

Since we're going to have to mess around with Makefiles in order to move or substitute in the build ID, we won't take this for 0.3.1.

0.5 is still a possibility however.

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 242165 [details] [diff] [review]
v1

Removing myself from review request, as I'm no longer doing calendar work.  Note that one-review should soon be enough, so there's no need to re-add a second reviewer, I think.

Comment 7

[Matthew (lilmatt) Willis]

nightrat,
Can you provide a new patch with the necessary values find-and-replaced from the Makefile?

Comment 8

[Matthew (lilmatt) Willis]

Not going to make the 0.5 train.

Comment 9

[Matthew (lilmatt) Willis]

Comment on attachment 242165 [details] [diff] [review]
v1

Minusing based on comment #7.

Comment 10

[Vlado Valastiak [:wladow]]

What's the status here? Locales count is growing with each released version, this really should be fixed.

Comment 11

[Stefan Sitter [:ssitter]]

Thorsten, do you plan to post an updated patch?

Comment 12

[Daniel Boelzle [:dbo]]

Attachment: patch - v1

This patch localizes lightning's addon info, removes the build id.
I've played around with moving the build id into the version, sticking to the major.minor.micro.build-id schema, e.g. 1.0.0pre.20081131 but this looked quite odd to me. Moreover a micro version is quite uncommon. Thinking further about it, I dropped the build id, because it's foremost only used by nightly testers which could use Thunderbird's build id once lightning is integrated.
Moreover the patch fixes calendar-timezones' thunderbird dependency

Comment 13

[Vlado Valastiak [:wladow]]

What about approach introduced with Gecko 1.9?
https://developer.mozilla.org/en/Localizing_extension_descriptions

It's more robust than previous one, f.e. it allows to see localized description when ext. is disabled.

Comment 14

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 348560 [details] [diff] [review]
patch - v1

I'll r+ this patch, but I'd consider the gecko 1.9 way of doing things.

I've played with the install.rdf stuff before and found it to be a build config nightmare, especially when trying to create multi-lang xpi's.

I guess thats a non-issue since ause is getting rid of that code.

Comment 15

[Daniel Boelzle [:dbo]]

(In reply to comment #14)
> I've played with the install.rdf stuff before and found it to be a build config
> nightmare, especially when trying to create multi-lang xpi's.

Thanks for the pointer, but I think unless there is reasonable build scripting for multi-l10n, I'll stick to the old scheme. I don't see anyone using the new stuff on mozilla-central: <http://mxr.mozilla.org/mozilla-central/search?string=em:localized>


Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/61d982bc92ea>

-> FIXED

Comment 16

[Philipp Kewisch [:Fallen][📱📆]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".