Unused message JSMSG_NAME_AFTER_FOR_PAREN

RESOLVED FIXED in mozilla27

Status

()

Core
JavaScript Engine
--
trivial
RESOLVED FIXED
12 years ago
5 years ago

People

(Reporter: Jesse Ruderman, Assigned: sciguyryan)

Tracking

Trunk
mozilla27
PowerPC
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Comment 1

12 years ago
Created attachment 241611 [details] [diff] [review]
Patch to remove.

Patch to remove the JSMSG_NAME_AFTER_FOR_PAREN message.
Attachment #241611 - Flags: superreview?(brendan)
Attachment #241611 - Flags: review?(brendan)
Comment on attachment 241611 [details] [diff] [review]
Patch to remove.

Thanks for noticing this.  See the comment at the top about preserving dense indexes by replacing any old rows with UNUSEDnnn.

/be
Attachment #241611 - Flags: superreview?(brendan)
Attachment #241611 - Flags: review?(brendan)
Attachment #241611 - Flags: review-
(Assignee)

Comment 3

12 years ago
Created attachment 241631 [details] [diff] [review]
Don't remove. Edit.

Replace message name |JSMSG_NAME_AFTER_FOR_PAREN| with |JSMSG_UNUSED210| and set the values according to Brendan's comments.
Attachment #241611 - Attachment is obsolete: true
Attachment #241631 - Flags: review?(brendan)
Comment on attachment 241631 [details] [diff] [review]
Don't remove. Edit.

r+me, thanks.

/be
Attachment #241631 - Flags: review?(brendan) → review+
https://hg.mozilla.org/mozilla-central/rev/eb81545460c4
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27

Updated

5 years ago
Assignee: general → sciguyryan
You need to log in before you can comment on or make changes to this bug.