Closed Bug 355930 Opened 13 years ago Closed 6 years ago

Unused message JSMSG_NAME_AFTER_FOR_PAREN

Categories

(Core :: JavaScript Engine, defect, trivial)

PowerPC
macOS
defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: jruderman, Assigned: sciguyryan)

References

()

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch to remove. (obsolete) — Splinter Review
Patch to remove the JSMSG_NAME_AFTER_FOR_PAREN message.
Attachment #241611 - Flags: superreview?(brendan)
Attachment #241611 - Flags: review?(brendan)
Comment on attachment 241611 [details] [diff] [review]
Patch to remove.

Thanks for noticing this.  See the comment at the top about preserving dense indexes by replacing any old rows with UNUSEDnnn.

/be
Attachment #241611 - Flags: superreview?(brendan)
Attachment #241611 - Flags: review?(brendan)
Attachment #241611 - Flags: review-
Replace message name |JSMSG_NAME_AFTER_FOR_PAREN| with |JSMSG_UNUSED210| and set the values according to Brendan's comments.
Attachment #241611 - Attachment is obsolete: true
Attachment #241631 - Flags: review?(brendan)
Comment on attachment 241631 [details] [diff] [review]
Don't remove. Edit.

r+me, thanks.

/be
Attachment #241631 - Flags: review?(brendan) → review+
https://hg.mozilla.org/mozilla-central/rev/eb81545460c4
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Assignee: general → sciguyryan
You need to log in before you can comment on or make changes to this bug.