Closed
Bug 355930
Opened 20 years ago
Closed 13 years ago
Unused message JSMSG_NAME_AFTER_FOR_PAREN
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: jruderman, Assigned: sciguyryan)
References
()
Details
Attachments
(1 file, 1 obsolete file)
|
1.05 KB,
patch
|
brendan
:
review+
|
Details | Diff | Splinter Review |
|
Assignee | |
Comment 1•20 years ago
|
||
Patch to remove the JSMSG_NAME_AFTER_FOR_PAREN message.
Attachment #241611 -
Flags: superreview?(brendan)
Attachment #241611 -
Flags: review?(brendan)
|
||
Comment 2•20 years ago
|
||
Comment on attachment 241611 [details] [diff] [review]
Patch to remove.
Thanks for noticing this. See the comment at the top about preserving dense indexes by replacing any old rows with UNUSEDnnn.
/be
Attachment #241611 -
Flags: superreview?(brendan)
Attachment #241611 -
Flags: review?(brendan)
Attachment #241611 -
Flags: review-
|
|
Assignee | |
Comment 3•20 years ago
|
||
Replace message name |JSMSG_NAME_AFTER_FOR_PAREN| with |JSMSG_UNUSED210| and set the values according to Brendan's comments.
Attachment #241611 -
Attachment is obsolete: true
Attachment #241631 -
Flags: review?(brendan)
|
|
||
Comment 4•20 years ago
|
||
Comment on attachment 241631 [details] [diff] [review]
Don't remove. Edit.
r+me, thanks.
/be
Attachment #241631 -
Flags: review?(brendan) → review+
|
||
Comment 5•13 years ago
|
||
Ryan, thanks for the patch.
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb81545460c4
|
|
||
Comment 6•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
|
||
Updated•13 years ago
|
Assignee: general → sciguyryan
You need to log in
before you can comment on or make changes to this bug.
Description
•