Last Comment Bug 356011 - kfreebsd support
: kfreebsd support
Status: RESOLVED FIXED
[not needed for 1.9]
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: x86 Linux
: -- normal (vote)
: mozilla1.9beta5
Assigned To: Mike Hommey [:glandium]
:
: Gregory Szorc [:gps]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-10-09 04:39 PDT by Petr.Salinger
Modified: 2012-05-24 23:58 PDT (History)
9 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
proposed patch (14.83 KB, patch)
2006-10-09 04:41 PDT, Petr.Salinger
no flags Details | Diff | Splinter Review
addtional patch (4.40 KB, patch)
2006-11-21 05:17 PST, Petr.Salinger
no flags Details | Diff | Splinter Review
patch for main configure.in and xpcom (4.49 KB, patch)
2008-03-08 02:44 PST, Mike Hommey [:glandium]
no flags Details | Diff | Splinter Review
patch for nss (9.55 KB, patch)
2008-03-08 02:47 PST, Mike Hommey [:glandium]
no flags Details | Diff | Splinter Review
patch for directory/ (4.98 KB, patch)
2008-03-08 02:50 PST, Mike Hommey [:glandium]
mcs: review+
Details | Diff | Splinter Review
patch for main configure.in and xpcom (4.50 KB, patch)
2008-03-08 02:54 PST, Mike Hommey [:glandium]
benjamin: review+
dsicore: approval1.9+
Details | Diff | Splinter Review
additional patch for LDAP-C-SDK (1.85 KB, patch)
2010-03-04 12:09 PST, Christoph Göhre
no flags Details | Diff | Splinter Review

Description Petr.Salinger 2006-10-09 04:39:03 PDT
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.8) Gecko/20060904 Debian/1.7.8-1sarge7.2.2
Build Identifier: N/A

Please, could you add support for GNU/kFreeBSD into main module ?

The patch are mainly
"defined(LINUX)"  -> "defined(LINUX) || defined(__GLIBC__)"

The notable exception is "security/coreconf/Linux.mk".
In this part , snippet for selecting OS_REL_CFLAGS and CPU_ARCH have been refactored  first and after that kfreebsd support have been added.

The support in NSPR  is already checked in (bz 261649).

Thanks

Petr




Reproducible: Always
Comment 1 Petr.Salinger 2006-10-09 04:41:11 PDT
Created attachment 241691 [details] [diff] [review]
proposed patch
Comment 2 Petr.Salinger 2006-11-21 05:17:46 PST
Created attachment 246147 [details] [diff] [review]
addtional patch

Please, could you also include this patch. The previous one is sufficient for web browser, this together with previous makes email client buildable.

Thanks

Petr
Comment 3 Mike Hommey [:glandium] 2008-03-08 02:44:48 PST
Created attachment 308126 [details] [diff] [review]
patch for main configure.in and xpcom

I'll split out the patches and request review to the (i hope) right persons. This one is for xpcom and main configure.in
Comment 4 Mike Hommey [:glandium] 2008-03-08 02:47:22 PST
Created attachment 308127 [details] [diff] [review]
patch for nss
Comment 5 Reed Loden [:reed] (use needinfo?) 2008-03-08 02:47:24 PST
Comment on attachment 308126 [details] [diff] [review]
patch for main configure.in and xpcom

>+	kfreebsd*-gnu) OS_ARCH=GNU_kFreeBSD OS_TARGET=GNU_kFreeBSD ;;

Spaces, not tabs.
Comment 6 Mike Hommey [:glandium] 2008-03-08 02:50:36 PST
Created attachment 308128 [details] [diff] [review]
patch for directory/
Comment 7 Mike Hommey [:glandium] 2008-03-08 02:54:49 PST
Created attachment 308129 [details] [diff] [review]
patch for main configure.in and xpcom

> Spaces, not tabs.

You caught me
Comment 8 Damon Sicore (:damons) 2008-03-11 14:52:36 PDT
Comment on attachment 308129 [details] [diff] [review]
patch for main configure.in and xpcom

a1.9+=damons
Comment 9 Reed Loden [:reed] (use needinfo?) 2008-03-12 03:59:29 PDT
Checking in configure.in;
/cvsroot/mozilla/configure.in,v  <--  configure.in
new revision: 1.1952; previous revision: 1.1951
done
Checking in xpcom/reflect/xptcall/src/md/unix/Makefile.in;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/Makefile.in,v  <--  Makefile.in
new revision: 1.101; previous revision: 1.100
done
Checking in xpcom/reflect/xptcall/src/md/unix/xptc_platforms_unixish_x86.h;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptc_platforms_unixish_x86.h,v  <--  xptc_platforms_unixish_x86.h
new revision: 1.23; previous revision: 1.22
done
Comment 10 neuroc0der@gmail.com 2008-03-12 04:13:24 PDT
this patch looks harmless to me. would be good tho to do linux build before checking all the changes in just to make sure there are no side effects. i
dont have appropriate rights to flag reviews so please request it from Mark
[ mcs at pearlcrescent.com ] instead.

Comment 11 Mark Smith (:mcs) 2008-03-12 13:36:31 PDT
Added Rich Megginson to the bug CC.
Comment 12 Mark Smith (:mcs) 2008-03-12 13:38:12 PDT
Comment on attachment 308128 [details] [diff] [review]
patch for directory/

The patch looks OK.  Rich, please take a look if you get a chance (Rich has done a lot of work on autoconf, etc. for the LDAP code).
Comment 13 Rich Megginson 2008-03-13 14:06:40 PDT
The patch for directory includes a patch for ldap/libraries/libldap/Makefile.client - afaik this is not used anymore - did you mean ldap/libraries/libldap/Makefile.in or is that file already correct?
Comment 14 Ted Mielczarek [:ted.mielczarek] 2008-05-09 11:15:01 PDT
What's the status here, you just haven't landed the NSS bits?
Comment 15 Reed Loden [:reed] (use needinfo?) 2008-10-20 04:46:08 PDT
wtc, can you review the NSS parts?
Comment 16 Petr.Salinger 2009-09-24 06:50:52 PDT
Please, could you look at it.
Additionaly, against current NSS is needed also

--- mozilla/security/nss/lib/softoken/softoken.h
+++ mozilla/security/nss/lib/softoken/softoken.h
@@ -303,7 +303,7 @@

 #define CHECK_FORK_MIXED

-#elif defined(LINUX)
+#elif defined(LINUX) || defined (__GLIBC__)

 #define CHECK_FORK_PTHREAD

Under GNU/kFreeBSD threads are process clones,
similarly as under linux 2.4 series,
it is not possible to use CHECK_FORK_GETPID implementation.
Comment 17 Christoph Göhre 2010-03-04 12:09:03 PST
Created attachment 430394 [details] [diff] [review]
additional patch for LDAP-C-SDK

Additional patch to add kfreebsd support in LDAP-C-SDK. Needed to build Thunderbird on kfreebsd.
Comment 18 Phoenix 2012-02-28 07:11:21 PST
Is this still actual?
Comment 19 Mike Hommey [:glandium] 2012-02-28 07:37:48 PST
Part is, part isn't. I'll file separate bugs on the relevant components for the remaining bits.

Note You need to log in before you can comment on or make changes to this bug.