Status

defect
RESOLVED FIXED
13 years ago
Last year

People

(Reporter: Petr.Salinger, Assigned: glandium)

Tracking

Trunk
mozilla1.9beta5
x86
Linux

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [not needed for 1.9])

Attachments

(4 attachments, 3 obsolete attachments)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.8) Gecko/20060904 Debian/1.7.8-1sarge7.2.2
Build Identifier: N/A

Please, could you add support for GNU/kFreeBSD into main module ?

The patch are mainly
"defined(LINUX)"  -> "defined(LINUX) || defined(__GLIBC__)"

The notable exception is "security/coreconf/Linux.mk".
In this part , snippet for selecting OS_REL_CFLAGS and CPU_ARCH have been refactored  first and after that kfreebsd support have been added.

The support in NSPR  is already checked in (bz 261649).

Thanks

Petr




Reproducible: Always
Posted patch proposed patch (obsolete) — Splinter Review
Component: Build Config → General
Component: General → Build Config
Product: Firefox → Core
Version: unspecified → Trunk
QA Contact: build.config → build-config
Posted patch addtional patch (obsolete) — Splinter Review
Please, could you also include this patch. The previous one is sufficient for web browser, this together with previous makes email client buildable.

Thanks

Petr
Status: UNCONFIRMED → NEW
Ever confirmed: true
I'll split out the patches and request review to the (i hope) right persons. This one is for xpcom and main configure.in
Assignee: nobody → mh+mozilla
Attachment #241691 - Attachment is obsolete: true
Attachment #246147 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #308126 - Flags: review?(benjamin)
Posted patch patch for nssSplinter Review
Attachment #308127 - Flags: review?(wtc)
Comment on attachment 308126 [details] [diff] [review]
patch for main configure.in and xpcom

>+	kfreebsd*-gnu) OS_ARCH=GNU_kFreeBSD OS_TARGET=GNU_kFreeBSD ;;

Spaces, not tabs.
Attachment #308128 - Flags: review?(anton.bobrov)
> Spaces, not tabs.

You caught me
Attachment #308126 - Attachment is obsolete: true
Attachment #308129 - Flags: review?(benjamin)
Attachment #308126 - Flags: review?(benjamin)
Attachment #308129 - Flags: review?(benjamin) → review+
Attachment #308129 - Flags: approval1.9?
Comment on attachment 308129 [details] [diff] [review]
patch for main configure.in and xpcom

a1.9+=damons
Attachment #308129 - Flags: approval1.9? → approval1.9+
Checking in configure.in;
/cvsroot/mozilla/configure.in,v  <--  configure.in
new revision: 1.1952; previous revision: 1.1951
done
Checking in xpcom/reflect/xptcall/src/md/unix/Makefile.in;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/Makefile.in,v  <--  Makefile.in
new revision: 1.101; previous revision: 1.100
done
Checking in xpcom/reflect/xptcall/src/md/unix/xptc_platforms_unixish_x86.h;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptc_platforms_unixish_x86.h,v  <--  xptc_platforms_unixish_x86.h
new revision: 1.23; previous revision: 1.22
done
Keywords: checkin-needed
Summary: [patch] kfreebsd support → kfreebsd support
Target Milestone: --- → mozilla1.9beta5
this patch looks harmless to me. would be good tho to do linux build before checking all the changes in just to make sure there are no side effects. i
dont have appropriate rights to flag reviews so please request it from Mark
[ mcs at pearlcrescent.com ] instead.

Attachment #308128 - Flags: review?(anton.bobrov) → review?(mcs)
Added Rich Megginson to the bug CC.
Comment on attachment 308128 [details] [diff] [review]
patch for directory/

The patch looks OK.  Rich, please take a look if you get a chance (Rich has done a lot of work on autoconf, etc. for the LDAP code).
Attachment #308128 - Flags: review?(mcs) → review+
The patch for directory includes a patch for ldap/libraries/libldap/Makefile.client - afaik this is not used anymore - did you mean ldap/libraries/libldap/Makefile.in or is that file already correct?
What's the status here, you just haven't landed the NSS bits?
Whiteboard: [not needed for 1.9]
wtc, can you review the NSS parts?
Please, could you look at it.
Additionaly, against current NSS is needed also

--- mozilla/security/nss/lib/softoken/softoken.h
+++ mozilla/security/nss/lib/softoken/softoken.h
@@ -303,7 +303,7 @@

 #define CHECK_FORK_MIXED

-#elif defined(LINUX)
+#elif defined(LINUX) || defined (__GLIBC__)

 #define CHECK_FORK_PTHREAD

Under GNU/kFreeBSD threads are process clones,
similarly as under linux 2.4 series,
it is not possible to use CHECK_FORK_GETPID implementation.
Additional patch to add kfreebsd support in LDAP-C-SDK. Needed to build Thunderbird on kfreebsd.
Is this still actual?
Part is, part isn't. I'll file separate bugs on the relevant components for the remaining bits.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Attachment #308127 - Flags: review?(wtc)
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.