Closed
Bug 356011
Opened 18 years ago
Closed 12 years ago
kfreebsd support
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9beta5
People
(Reporter: Petr.Salinger, Assigned: glandium)
Details
(Whiteboard: [not needed for 1.9])
Attachments
(4 files, 3 obsolete files)
9.55 KB,
patch
|
Details | Diff | Splinter Review | |
4.98 KB,
patch
|
mcs
:
review+
|
Details | Diff | Splinter Review |
4.50 KB,
patch
|
benjamin
:
review+
damons
:
approval1.9+
|
Details | Diff | Splinter Review |
1.85 KB,
patch
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.8) Gecko/20060904 Debian/1.7.8-1sarge7.2.2 Build Identifier: N/A Please, could you add support for GNU/kFreeBSD into main module ? The patch are mainly "defined(LINUX)" -> "defined(LINUX) || defined(__GLIBC__)" The notable exception is "security/coreconf/Linux.mk". In this part , snippet for selecting OS_REL_CFLAGS and CPU_ARCH have been refactored first and after that kfreebsd support have been added. The support in NSPR is already checked in (bz 261649). Thanks Petr Reproducible: Always
Reporter | ||
Comment 1•18 years ago
|
||
Reporter | ||
Updated•18 years ago
|
Component: Build Config → General
Updated•18 years ago
|
Component: General → Build Config
Product: Firefox → Core
Version: unspecified → Trunk
Updated•18 years ago
|
QA Contact: build.config → build-config
Reporter | ||
Comment 2•18 years ago
|
||
Please, could you also include this patch. The previous one is sufficient for web browser, this together with previous makes email client buildable. Thanks Petr
Updated•18 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 3•16 years ago
|
||
I'll split out the patches and request review to the (i hope) right persons. This one is for xpcom and main configure.in
Assignee: nobody → mh+mozilla
Attachment #241691 -
Attachment is obsolete: true
Attachment #246147 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #308126 -
Flags: review?(benjamin)
Assignee | ||
Comment 4•16 years ago
|
||
Attachment #308127 -
Flags: review?(wtc)
Comment 5•16 years ago
|
||
Comment on attachment 308126 [details] [diff] [review] patch for main configure.in and xpcom >+ kfreebsd*-gnu) OS_ARCH=GNU_kFreeBSD OS_TARGET=GNU_kFreeBSD ;; Spaces, not tabs.
Assignee | ||
Comment 6•16 years ago
|
||
Attachment #308128 -
Flags: review?(anton.bobrov)
Assignee | ||
Comment 7•16 years ago
|
||
> Spaces, not tabs.
You caught me
Attachment #308126 -
Attachment is obsolete: true
Attachment #308129 -
Flags: review?(benjamin)
Attachment #308126 -
Flags: review?(benjamin)
Updated•16 years ago
|
Attachment #308129 -
Flags: review?(benjamin) → review+
Assignee | ||
Updated•16 years ago
|
Attachment #308129 -
Flags: approval1.9?
Comment 8•16 years ago
|
||
Comment on attachment 308129 [details] [diff] [review] patch for main configure.in and xpcom a1.9+=damons
Attachment #308129 -
Flags: approval1.9? → approval1.9+
Updated•16 years ago
|
Keywords: checkin-needed
Comment 9•16 years ago
|
||
Checking in configure.in; /cvsroot/mozilla/configure.in,v <-- configure.in new revision: 1.1952; previous revision: 1.1951 done Checking in xpcom/reflect/xptcall/src/md/unix/Makefile.in; /cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/Makefile.in,v <-- Makefile.in new revision: 1.101; previous revision: 1.100 done Checking in xpcom/reflect/xptcall/src/md/unix/xptc_platforms_unixish_x86.h; /cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptc_platforms_unixish_x86.h,v <-- xptc_platforms_unixish_x86.h new revision: 1.23; previous revision: 1.22 done
Keywords: checkin-needed
Summary: [patch] kfreebsd support → kfreebsd support
Target Milestone: --- → mozilla1.9beta5
Comment 10•16 years ago
|
||
this patch looks harmless to me. would be good tho to do linux build before checking all the changes in just to make sure there are no side effects. i dont have appropriate rights to flag reviews so please request it from Mark [ mcs at pearlcrescent.com ] instead.
Assignee | ||
Updated•16 years ago
|
Attachment #308128 -
Flags: review?(anton.bobrov) → review?(mcs)
Comment 11•16 years ago
|
||
Added Rich Megginson to the bug CC.
Comment 12•16 years ago
|
||
Comment on attachment 308128 [details] [diff] [review] patch for directory/ The patch looks OK. Rich, please take a look if you get a chance (Rich has done a lot of work on autoconf, etc. for the LDAP code).
Attachment #308128 -
Flags: review?(mcs) → review+
Comment 13•16 years ago
|
||
The patch for directory includes a patch for ldap/libraries/libldap/Makefile.client - afaik this is not used anymore - did you mean ldap/libraries/libldap/Makefile.in or is that file already correct?
Comment 14•16 years ago
|
||
What's the status here, you just haven't landed the NSS bits?
Updated•16 years ago
|
Whiteboard: [not needed for 1.9]
Comment 15•16 years ago
|
||
wtc, can you review the NSS parts?
Reporter | ||
Comment 16•15 years ago
|
||
Please, could you look at it. Additionaly, against current NSS is needed also --- mozilla/security/nss/lib/softoken/softoken.h +++ mozilla/security/nss/lib/softoken/softoken.h @@ -303,7 +303,7 @@ #define CHECK_FORK_MIXED -#elif defined(LINUX) +#elif defined(LINUX) || defined (__GLIBC__) #define CHECK_FORK_PTHREAD Under GNU/kFreeBSD threads are process clones, similarly as under linux 2.4 series, it is not possible to use CHECK_FORK_GETPID implementation.
Comment 17•14 years ago
|
||
Additional patch to add kfreebsd support in LDAP-C-SDK. Needed to build Thunderbird on kfreebsd.
Comment 18•12 years ago
|
||
Is this still actual?
Assignee | ||
Comment 19•12 years ago
|
||
Part is, part isn't. I'll file separate bugs on the relevant components for the remaining bits.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•12 years ago
|
Attachment #308127 -
Flags: review?(wtc)
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•