Closed Bug 356154 Opened 18 years ago Closed 17 years ago

Alt+Letter doesn't activate the native menu of an embedder

Categories

(Core :: Widget: Win32, defect)

Product:
Core
Component:
Widget: Win32
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9beta1

People

(Reporter: boissomag, Assigned: boissomag)

Details

Attachments

(1 file, 2 obsolete files)

Updated for last trunk update
2.11 KB, patch
roc
: superreview+
roc
: approval1.9+
Details | Diff | Splinter Review 
Easy to reproduce with mfcembed. As long as gecko is focused, alt+F do nothing.
Attached patch Quick fix (obsolete) — — Splinter Review 
Send a WM_SYSCHAR message for default processing if it wasn't used by gecko.
Assignee: win32 → boissomag
Status: NEW → ASSIGNED
Attachment #241824 - Flags: review?(emaijala)
Comment on attachment 241824 [details] [diff] [review]
Quick fix

I can't see mToolkit::mDefWindowProc anywhere. Did you mean to just call ::DefWindowProcW?
Ah! yes, sorry. I was working on the 1.8 branch and forgot to change the call.
Comment on attachment 241824 [details] [diff] [review]
Quick fix

Please create a corrected trunk patch. I could of course just change this for testing, but it's better to have the correct one attached and reviewed. Thanks.
Attachment #241824 - Flags: review?(emaijala) → review-
Attached patch Corrected Patch (obsolete) — — Splinter Review 
Of course, sorry for the delay.
Attachment #241824 - Attachment is obsolete: true
Attachment #242482 - Flags: review?(emaijala)
Comment on attachment 242482 [details] [diff] [review]
Corrected Patch

This should work.
Attachment #242482 - Flags: review?(emaijala) → review+

        Attachment #242482 -
        Attachment is obsolete: true

        Attachment #284818 -
        Flags: superreview?

    
  

        Attachment #284818 -
        Flags: superreview? → superreview?(roc)

        Attachment #284818 -
        Flags: superreview?(roc)

        Attachment #284818 -
        Flags: superreview+

        Attachment #284818 -
        Flags: approval1.9+

    
  
Keywords: checkin-needed
QA Contact: ian → win32

    
    

    
  
Checking in widget/src/windows/nsWindow.cpp;
/cvsroot/mozilla/widget/src/windows/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 3.712; previous revision: 3.711
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M9

    
  
Keywords: checkin-needed

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: