356261 - lightning-wcap builds don't function properly

Status: VERIFIED FIXED

(Calendar :: Lightning Only, defect)

Description

[Daniel Boelzle [:dbo]]

Some users reported that they face the problem that the lightning-wcap builds don't function correctly, i.e. they have to manually set the missing calendar.wcap.enabled resp. calendar.prototypes.wcap prefs.
However I couldn't reproduce that problem on my TB 1.5.0.7, I assume it relates to a different installation order of the two inherent packages, i.e. wcap-enabler.xpi is installed *before* lightning.xpi where the latter sets the pref to false.

A solution I can imagine is to omit setting those two prefs explicitly to false in calendar/lightning/content/lightning.js. This is no problem, because the corresponding code reading those pref is graceful if those prefs do not exist (assuming they are false).

Comment 1

[Matthew (lilmatt) Willis]

Fixed in the 0.3 lightning-wcap builds only.

Comment 2

[Matthew (lilmatt) Willis]

Attachment: removes prefs that by default disable wcap stuff

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 241946 [details] [diff] [review]
removes prefs that by default disable wcap stuff

r=dmose, once we've verified with the new 0.3 wcap builds that this change actually fixes the issue.

Comment 4

[Matthew (lilmatt) Willis]

ssa verified it fixes the issue.

Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED

Comment 5

[Daniel Boelzle [:dbo]]

IMO it's sensible to take this patch for 0.3.1.

Comment 6

[Matthew (lilmatt) Willis]

Patch checked in for 0.3.1

LIGHTNING_0_3_BRANCH:
Checking in lightning.js;
/cvsroot/mozilla/calendar/lightning/content/lightning.js,v  <--  lightning.js
new revision: 1.2.2.8.2.1; previous revision: 1.2.2.8

SUNBIRD_0_3_BRANCH:
Checking in lightning.js;
/cvsroot/mozilla/calendar/lightning/content/lightning.js,v  <--  lightning.js
new revision: 1.8.2.1; previous revision: 1.8

Marking [fixed0.3.1]

Comment 7

[cmtalbert]

Not going to mark this as Verified, since I'm not totally clear on how to reproduce the scenario.  But, I will add that WCAP 0.3.1 is working for me on Tbird 1.5.9. Thunderbird: version 1.5.0.9 (20061207) Lightning 0.3.1 + WCAP: 2007020304.

--> VERIFIED?

Comment 8

[Ulf Stroehler]

fix verified in lightning 0.3.1 (build 20070203).