The default bug view has changed. See this FAQ.

Enable MSAA-only code only on windows

RESOLVED FIXED

Status

()

Core
Disability Access APIs
RESOLVED FIXED
11 years ago
6 years ago

People

(Reporter: Håkan Waara, Assigned: Håkan Waara)

Tracking

(Blocks: 1 bug)

Trunk
PowerPC
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [bk1])

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
There's some code that relies on the fact that #ifndef MOZ_ACCESSIBILITY_ATK is the same as being on Windows. This is not the fact anymore...
(Assignee)

Comment 1

11 years ago
Created attachment 241967 [details] [diff] [review]
Patch for caret code (checked in)

I'll keep this bug open for other instances where we have to make code XP_WIN-only (I don't want to do a mass-change before I know what the change in behavior would be).

Here's a fix to only enable some caret notification code on windows, and let ATK/mac share the other code.
Attachment #241967 - Flags: review?(aaronleventhal)

Updated

11 years ago
Attachment #241967 - Flags: review?(aaronleventhal) → review+
(Assignee)

Comment 2

11 years ago
Comment on attachment 241967 [details] [diff] [review]
Patch for caret code (checked in)

I've checked this in. I'll keep this bug open in case there will be other patches where we'll have to remove ATK #ifndefs to XP_WIN
Attachment #241967 - Attachment description: Do this for caret code → Patch for caret code (checked in)

Updated

10 years ago
Blocks: 389800
I took a look, and there are no more places where this pattern occurs. There still are platform ifdefs in the base code but they all seem sensible and they don't imply a platform by negation.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [bk1]
You need to log in before you can comment on or make changes to this bug.