Last Comment Bug 356294 - Enable MSAA-only code only on windows
: Enable MSAA-only code only on windows
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: Trunk
: PowerPC Mac OS X
: -- normal (vote)
: ---
Assigned To: Håkan Waara
: alexander :surkov
Depends on:
Blocks: cleana11y
  Show dependency treegraph
Reported: 2006-10-11 10:15 PDT by Håkan Waara
Modified: 2011-11-01 06:55 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch for caret code (checked in) (946 bytes, patch)
2006-10-11 10:21 PDT, Håkan Waara
aaronlev: review+
Details | Diff | Splinter Review

Description Håkan Waara 2006-10-11 10:15:22 PDT
There's some code that relies on the fact that #ifndef MOZ_ACCESSIBILITY_ATK is the same as being on Windows. This is not the fact anymore...
Comment 1 Håkan Waara 2006-10-11 10:21:17 PDT
Created attachment 241967 [details] [diff] [review]
Patch for caret code (checked in)

I'll keep this bug open for other instances where we have to make code XP_WIN-only (I don't want to do a mass-change before I know what the change in behavior would be).

Here's a fix to only enable some caret notification code on windows, and let ATK/mac share the other code.
Comment 2 Håkan Waara 2006-10-12 07:51:06 PDT
Comment on attachment 241967 [details] [diff] [review]
Patch for caret code (checked in)

I've checked this in. I'll keep this bug open in case there will be other patches where we'll have to remove ATK #ifndefs to XP_WIN
Comment 3 Eitan Isaacson [:eeejay] 2011-11-01 06:55:00 PDT
I took a look, and there are no more places where this pattern occurs. There still are platform ifdefs in the base code but they all seem sensible and they don't imply a platform by negation.

Note You need to log in before you can comment on or make changes to this bug.