Closed Bug 356363 Opened 13 years ago Closed 13 years ago

calendar-month-view's calObserver needs to get its scoping straight

Categories

(Calendar :: Calendar Views, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Sunbird 0.5

People

(Reporter: jminta, Assigned: jminta)

Details

(Keywords: perf)

Attachments

(1 file)

This has to be a huge hit during import.  calendar-month-view's calObserver is oftentimes looking at it's own batchCount, rather than the calView's batchCount.  Compare http://lxr.mozilla.org/mozilla/source/calendar/base/content/calendar-month-view.xml#1374 and http://lxr.mozilla.org/mozilla/source/calendar/base/content/calendar-month-view.xml#1377
Attached patch fix targetSplinter Review
Just fixes the target and also a likely strict warning.
Assignee: nobody → jminta
Status: NEW → ASSIGNED
Attachment #247884 - Flags: second-review?(dmose)
Attachment #247884 - Flags: first-review?(lilmatt)
Comment on attachment 247884 [details] [diff] [review]
fix target

r=lilmatt
Attachment #247884 - Flags: first-review?(lilmatt) → first-review+
Comment on attachment 247884 [details] [diff] [review]
fix target

r2=dmose
Attachment #247884 - Flags: second-review?(dmose) → second-review+
Whiteboard: [needs checkin]
Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [needs checkin]
Target Milestone: --- → Sunbird 0.5
You need to log in before you can comment on or make changes to this bug.