Closed
Bug 356363
Opened 18 years ago
Closed 17 years ago
calendar-month-view's calObserver needs to get its scoping straight
Categories
(Calendar :: Calendar Frontend, defect)
Calendar
Calendar Frontend
Tracking
(Not tracked)
RESOLVED
FIXED
Sunbird 0.5
People
(Reporter: jminta, Assigned: jminta)
Details
(Keywords: perf)
Attachments
(1 file)
|
1.34 KB,
patch
|
mattwillis
:
first-review+
dmosedale
:
second-review+
|
Details | Diff | Splinter Review |
This has to be a huge hit during import. calendar-month-view's calObserver is oftentimes looking at it's own batchCount, rather than the calView's batchCount. Compare http://lxr.mozilla.org/mozilla/source/calendar/base/content/calendar-month-view.xml#1374 and http://lxr.mozilla.org/mozilla/source/calendar/base/content/calendar-month-view.xml#1377
|
Assignee | |
Comment 1•18 years ago
|
||
Just fixes the target and also a likely strict warning.
Assignee: nobody → jminta
Status: NEW → ASSIGNED
Attachment #247884 -
Flags: second-review?(dmose)
Attachment #247884 -
Flags: first-review?(lilmatt)
|
||
Comment 2•18 years ago
|
||
Comment on attachment 247884 [details] [diff] [review] fix target r=lilmatt
Attachment #247884 -
Flags: first-review?(lilmatt) → first-review+
|
||
Comment 3•17 years ago
|
||
Comment on attachment 247884 [details] [diff] [review] fix target r2=dmose
Attachment #247884 -
Flags: second-review?(dmose) → second-review+
|
|
||
Updated•17 years ago
|
Whiteboard: [needs checkin]
|
|
||
Comment 4•17 years ago
|
||
Patch checked in on MOZILLA_1_8_BRANCH and trunk. -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Whiteboard: [needs checkin]
Target Milestone: --- → Sunbird 0.5
You need to log in
before you can comment on or make changes to this bug.
Description
•