356533 - incomplete buttons with some themes

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Gerard Durand]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; fr; rv:1.8.1) Gecko/20061003 Firefox/2.0
Build Identifier: Mozilla Thunderbird version 2 beta 1 (20061012)

In "Day view", "week view" or "month view", some of the buttons at the top are not complete when using a theme such as Noia2, because this themen as rounded button. The missing part is on the left. A solution to this problem is to delete 4 lines in lighting.css, those containing margin: 0px; and padding: 0px in the items .title2 and .title0 (no such lines in .title1, so no problem).
With version 0.3 a new problem with the "rotate" button, in "Day view" and "week view", always with Noia2 theme. Here too button in not correct, but not the same effect as previously : left rounded part is missing, and right part appear above the central part of the button.


Reproducible: Always

Comment 1

[Gerard Durand]

Attachment: Display of the bugs

Comment 2

[cmtalbert]

Confirmed: Thunderbird version 2 beta 2 (20070122), Lightning: 2007012203, Noia Theme: 2.32
Windows XP Pro SP 2. 

Also confirmed on Mac PPC with same versions of Thunderbird, Lightning, and Noia.

Comment 3

[Gerard Durand]

Attachment: a version of lightning 0.3 with workarounds to the problems I described.

Modifications made in two files from chrome subfolder. Not perfect, but it works...

Comment 4

[Martin Schröder [:mschroeder]]

Gerard, you have to provide a diff file so we can see what you have changed in which file. Maybe you could do this for Lighning 0.5 RC1 (http://releases.mozilla.org/pub/mozilla.org/calendar/lightning/releases/0.5rc1/).

Comment 5

[Gerard Durand]

Sorry, I had problem today to download this new 0.51 version, but here are the modifications made on 0.31 version.
I have modified 2 files : lightning.css in classic.jar and calendar-multiday-view.xml in calendar.jar.
For lightning .css,
modifications are in line 106-107 and 125-126 (added simply a comment in margin and padding within .tile2 and .title 0. .title1 is OK).
here is the modified code :

.title2 {
    font-size:1.2em;
    color: #4e84c2;
/*    margin:0px;*/
/*    padding:0px;*/
    cursor:pointer;
    -moz-appearance: none;
    border: 0px;
}

.title0 {
    font-size:2.0em;
    color: #2e4e73;
    font-weight:bold;
/*    margin:0px;*/
/*    padding:0px; */
    -moz-appearance: none;
    border: 0px;
}

For calendar-multiday-view.xml, I modified lines 1561 to 1563 (in <binding id="calendar-multiday-view">):
Original lines are :
        <xul:box anonid="labelbox" align="center">
          <xul:box anonid="labeltimespacer" align="center">
            <xul:button style="min-width: 10px; background: red;"

Modified lines are :
        <xul:box anonid="labelbox">
          <xul:box anonid="labeltimespacer">
            <xul:button style="min-width: 10px; padding: 1px; background: red;" 

I simply deleted align="center" and padding: 1px in those lines.

Comment 6

[Stefan Sitter [:ssitter]]

Attachment: remove margin and padding rule

This patch removes the margin and padding from rule .title2 and .title0 as proposed by Gerard. I do not fix the Rotate button because it's going to be removed with Bug 378270.

Comment 7

[Stefan Sitter [:ssitter]]

Attachment: screenshot showing some themes with and without patch

I tested some popular themes from addons.mozilla.org. As you can see the width for the buttons slightly increases depend on the selected theme but the button issue is fixed.

Comment 9

[Stefan Sitter [:ssitter]]

Comment on attachment 271222 [details] [diff] [review]
remove margin and padding rule

Moving review to daniel to relieve mickey

Comment 10

[Michael Büttner (no reviews TFN)]

Comment on attachment 271222 [details] [diff] [review]
remove margin and padding rule

r=mickey.

Comment 11

[Michael Büttner (no reviews TFN)]

patch checked in on trunk and MOZILLA_1_8_BRANCH

-> FIXED