356740 - NSIS installer should remove all obsolete files during installation

Status: VERIFIED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Stefan Sitter [:ssitter]]

Follow up for Bug 355225.

Win32 NSIS installer should remove the following obsolete files that are leftovers from previous installation to prevent problems:

Leftovers from Sunbird 0.2 installation
=======================================
chrome/calendar-ca-AD.jar
chrome/calendar-cs-CZ.jar
chrome/calendar-cy-GB.jar
chrome/calendar-de-AT.jar
chrome/calendar-es-ES.jar
chrome/calendar-fr-FR.jar
chrome/calendar-hu-HU.jar
chrome/calendar-it-IT.jar
chrome/calendar-ja-JP.jar
chrome/calendar-lt-LT.jar
chrome/calendar-nl-NL.jar
chrome/calendar-pl-PL.jar
chrome/calendar-pt-BR.jar
chrome/calendar-sk-SK.jar
chrome/calendar-sl-SI.jar
chrome/calendar-sv-SE.jar
chrome/calendar-tr-TR.jar
chrome/calendar-wen-DE.jar
chrome/help.jar
chrome/pipnss.jar
components/browser.xpt
defaults/profile/mimeTypes.rdf
extensions/{8af2d0a7-e394-4de2-ae55-2dae532a7a9b}/install.rdf
extensions/Extensions.rdf
extensions/installed-extensions-processed.txt
plugins/
res/builtin/platformHTMLBindings.xml
res/platform-forms.css
xpcom_compat.dll


Leftovers from Sunbird 0.3a1/0.3a2 installation
===============================================
chrome/chromelist.txt
components/necko_data.xpt
components/xmlextras.xpt
plugins/npnul32.dll
res/dtd/mathml.dtd
res/dtd/mathml20.properties
res/fonts/mathfont.properties
res/fonts/mathfontCMEX10.properties
res/fonts/mathfontCMSY10.properties
res/fonts/mathfontMath1.properties
res/fonts/mathfontMath2.properties
res/fonts/mathfontMath4.properties
res/fonts/mathfontMTExtra.properties
res/fonts/mathfontPUA.properties
res/fonts/mathfontSymbol.properties
res/bloatcycle.html
res/EditorOverride.css
res/entityTables
res/grabber.gif
res/mathml.css
res/table-add-column-after-active.gif
res/table-add-column-after-hover.gif
res/table-add-column-after.gif
res/table-add-column-before-active.gif
res/table-add-column-before-hover.gif
res/table-add-column-before.gif
res/table-add-row-after-active.gif
res/table-add-row-after-hover.gif
res/table-add-row-after.gif
res/table-add-row-before-active.gif
res/table-add-row-before-hover.gif
res/table-add-row-before.gif
res/table-remove-column-active.gif
res/table-remove-column-hover.gif
res/table-remove-column.gif
res/table-remove-row-active.gif
res/table-remove-row-hover.gif
res/table-remove-row.gif
res/viewer.properties
dependentlibs.list
mozctl.dll
mozctlx.dll
regxpcom.exe
sunbird.url
unins000.dat
unins000.exe
xpcom_compat.dll
xpcshell.exe
xpidl.exe
xpt_dump.exe
xpt_link.exe

Comment 1

[Matthew (lilmatt) Willis]

From the Linux xpinstall installers, I suspect there will also be lib*.so versions of the .dlls and versions of the .exes without .exe

Oh the fun.

Comment 2

[Stefan Sitter [:ssitter]]

Attachment: clean out obsolete files from old installer

Clean out all obsolete files from old win32 installer versions. Tested with 0.2, 0.3a1 and 0.3a2 en-US installer from [http://ftp.mozilla.org/pub/mozilla.org/calendar/sunbird/releases/] on Windows 2000 system.

Comment 3

[Matthew (lilmatt) Willis]

Comment on attachment 242340 [details] [diff] [review]
clean out obsolete files from old installer

>Index: mozilla/calendar/installer/removed-files.in
>===================================================================
>+chrome/overlayinfo/browser/content/overlays.rdf
>+chrome/overlayinfo/browser/content/
>+chrome/overlayinfo/browser/skin/stylesheets.rdf
>+chrome/overlayinfo/browser/skin/
>+chrome/overlayinfo/browser/
>+chrome/overlayinfo/communicator/content/overlays.rdf
>+chrome/overlayinfo/communicator/content/
>+chrome/overlayinfo/communicator/
>+chrome/overlayinfo/global/skin/stylesheets.rdf
>+chrome/overlayinfo/global/skin/
>+chrome/overlayinfo/global/
>+chrome/overlayinfo/messenger/content/overlays.rdf
>+chrome/overlayinfo/messenger/content/
>+chrome/overlayinfo/messenger/
>+chrome/overlayinfo/navigator/content/overlays.rdf
>+chrome/overlayinfo/navigator/content/
>+chrome/overlayinfo/navigator/
>+chrome/overlayinfo/

Let's use
chrome/overlayinfo/*
chrome/overlayinfo/
instead.

>+extensions/{8af2d0a7-e394-4de2-ae55-2dae532a7a9b}/install.rdf
>+extensions/{8af2d0a7-e394-4de2-ae55-2dae532a7a9b}/
Same here.

>+res/builtin/platformHTMLBindings.xml
>+res/builtin/
and here.

>+plugins/npnul32.dll
>+plugins/
and here.

>+res/entityTables/mathml20.properties
>+res/entityTables/
and here.

r=lilmatt with that

Comment 4

[Stefan Sitter [:ssitter]]

(In reply to comment #3)

I think we should not use xyz/* here. Reason is that this will remove _all_ files in that directory and not only the files we know that can be removed safely. There might be other created files, files from extensions or plugins, data files the user decided to store in Sunbird program folder (for whatever reason), ...

Comment 5

[Matthew (lilmatt) Willis]

(In reply to comment #4)
> I think we should not use xyz/* here. Reason is that this will remove _all_
> files in that directory and not only the files we know that can be removed
> safely.
Okay, but you're deleting the directory in the last line of each of those sections, and IIRC deleting the directory _WILL_ delete its contents (aka rm -rf).

Comment 6

[Stefan Sitter [:ssitter]]

(In reply to comment #5)
I thought the installer was smart enough not to delete folders that still contain files. Apparently I'm wrong.

So in that case we could either remove only the files in question and leave behind empty folders. On the other hand do Firefox and Thunderbird a similar think, e.g. they list only 'chrome/overlayinfo/' in their 'removed-files.in' file. Or they explicit list the file to remove and than the folder. (Like in my patch). But none of them uses '*'.

Comment 7

[Matthew (lilmatt) Willis]

(In reply to comment #6)
> I thought the installer was smart enough not to delete folders that still
> contain files. Apparently I'm wrong.
http://lxr.mozilla.org/mozilla/source/calendar/installer/windows/nsis/installer.nsi#563

> On the other hand do Firefox and Thunderbird a similar think, e.g. they list
> only 'chrome/overlayinfo/' in their 'removed-files.in' file.
I'd follow their lead.

Comment 8

[Stefan Sitter [:ssitter]]

Attachment: clean out obsolete files from old installer, v2

Patch addresses some of the previous comments to shorten the patch. For example I did not replaced single file names with * so that it is easier to see/find what specific files are meant to be removed if someone works this file later. The rest was updated to match the 'style' already used by Firefox and Thunderbird.

Comment 9

[Matthew (lilmatt) Willis]

Comment on attachment 245014 [details] [diff] [review]
clean out obsolete files from old installer, v2

r=lilmatt

Comment 10

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 245014 [details] [diff] [review]
clean out obsolete files from old installer, v2

r2=mvl

Comment 11

[Matthew (lilmatt) Willis]

Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED

Comment 12

[Matthew (lilmatt) Willis]

Patch checked in for 0.3.1

LIGHTNING_0_3_BRANCH:
Checking in removed-files.in;
/cvsroot/mozilla/calendar/installer/removed-files.in,v  <--  removed-files.in
new revision: 1.1.2.3.2.1; previous revision: 1.1.2.3

SUNBIRD_0_3_BRANCH:
Checking in removed-files.in;
/cvsroot/mozilla/calendar/installer/removed-files.in,v  <--  removed-files.in
new revision: 1.3.2.3; previous revision: 1.3.2.2

Marking [fixed0.3.1]

Comment 13

[Stefan Sitter [:ssitter]]

Verified that Sunbird starts up after installing new Sunbird version over previous version. Tested update from 0.2/0.3a1/0.3a2/0.3 to 0.3.1 for both en and de locale, update from 0.2/0.3.1 to 0.4a1 (branch) for en locale.

Marking [verified0.3.1].