356813 - Add Bookmark shortcut gets confused with the Dvorak-Qwerty keyboard layout

Status: VERIFIED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Screwtape]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; chrome://navigator/locale/navigator.properties; rv:1.9a1) Gecko/20061013 Camino/1.2+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; chrome://navigator/locale/navigator.properties; rv:1.9a1) Gecko/20061013 Camino/1.2+

Recently I downloaded a new trunk build of Camino that had the fixes for bug 275170. To my surprise, when I hit Cmd-H to Hide Camino, Camino now pops up a dialog offering to bookmark the current page.

I have my keyboard layout set to Dvorak-Qwerty, so that it works like a Dvorak layout while typing normally, but temporarily switches to Qwerty when I hold down Cmd (so my muscle-memory for keyboard shortcuts doesn't get confused).

Reproducible: Always

Steps to Reproduce:
1. In System Preferences, go to the International Preference Pane, go to the Input Menu tab and enable the Dvorak-Qwerty keyboard layout. (in 10.4, it's about halfway down the list)
2. In the Input menu, make sure 'Dvorak-Qwerty' is the current keyboard layout.
3. Switch to Camino.
4. Press Cmd-H

Actual Results:  
Camino drops down the 'Add a bookmark' sheet, just like choosing 'Bookmark current page' from the Bookmarks menu.

Expected Results:  
Camino should be hidden.

In the Dvorak layout, D is where the H is in Qwerty, so I'm guessing Camino is saying 'What keycode produces "D"?' then assuming that that keycode in combination with Cmd should be bound to 'Add Bookmark'.

I should note that all the other keyboard shortcuts I can see in the menus work fine. Also, switching back to a standard Qwerty layout makes things behave properly.

It may be necessary to set the keyboard layout to Dvorak-Qwerty before starting Camino, I'm not sure.

Comment 1

[froodian (Ian Leue)]

Yeah, this is bug 275170 fallout, from when we changed the keyboard shortcut for "Add Bookmark" to Cmd-K, but kept Cmd-D on for legacy:

http://lxr.mozilla.org/mozilla/source/camino/src/browser/BrowserWindow.mm#134

I don't really know what the correct thing to do here is - I think the inconsistency comes from using |charactersIgnoringModifiers| to get the keycode, but the documentation seems to imply that we'll have trouble with international layouts if we don't use that.

Comment 2

[Stuart Morgan]

Attachment: just using characters

This seems like it should work for any layout except one where you can type a 'd' using option, shift, or control, which seems unlikely--and if that's the only way to type a 'd' it wouldn't work under the old method anyway.

Comment 3

[froodian (Ian Leue)]

Comment on attachment 242404 [details] [diff] [review]
just using characters

r=me

Comment 4

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 242404 [details] [diff] [review]
just using characters

sr=pink

Comment 5

[froodian (Ian Leue)]

Checked into trunk and 1.8branch

Comment 6

[froodian (Ian Leue)]

*** Bug 357241 has been marked as a duplicate of this bug. ***

Comment 7

[Screwtape]

I'm typing this from the 2006101922 build and I can verify that this bug is fixed.