Closed Bug 356851 Opened 14 years ago Closed 13 years ago

nsXPConnect::ReparentAllWrappersInScope uses wrong parents.

Categories

(Core :: XPConnect, defect, critical)

x86
Linux
defect
Not set
critical

Tracking

()

VERIFIED FIXED

People

(Reporter: bzbarsky, Assigned: peterv)

References

Details

(Keywords: verified1.8.0.9, verified1.8.1.1)

Attachments

(2 files)

See bug 333697 comment 42.

This probably breaks form control access in some cases, and XUL stuff in some other cases.

Given that we landed bug 333697 on branches, we should fix this there too.
This looks like a 1-line change, btw.  I just don't have the time to do the testing that would be needed...
Flags: blocking1.9?
Flags: blocking1.8.1.1?
Flags: blocking1.8.0.9?
Assignee: dbradley → nobody
peterv: can you get this one in for us?
Assignee: nobody → peterv
Flags: blocking1.8.1.1?
Flags: blocking1.8.1.1+
Flags: blocking1.8.0.9?
Flags: blocking1.8.0.9+
Attached patch v1Splinter Review
Attachment #245580 - Flags: superreview?(jst)
Attachment #245580 - Flags: review?(jst)
Comment on attachment 245580 [details] [diff] [review]
v1

r+sr=jst
Attachment #245580 - Flags: superreview?(jst)
Attachment #245580 - Flags: superreview+
Attachment #245580 - Flags: review?(jst)
Attachment #245580 - Flags: review+
As this is blocking1.8.1.1+, please either request approval1.8.1.1 on the current patch or, if needed, attach a branch version of the patch and request approval1.8.1.1 on it.

The same holds true for blocking1.8.0.9+.

Also, does this patch need to be committed to the trunk, or is it already there?
Status: NEW → ASSIGNED
Need a new patch for branch.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: need branch patch
(In reply to comment #8)
> Need a new patch for branch.

Can you do this, please? Code freeze is Friday.
Attachment #247050 - Flags: approval1.8.1.1?
Attachment #247050 - Flags: approval1.8.0.9?
Comment on attachment 247050 [details] [diff] [review]
v1 (branch version)

This patch is identical except for the line numbers. Don't normally need separate branch patches just for that.

approved for 1.8/1.8.0 branches, a=dveditz
Attachment #247050 - Flags: approval1.8.1.1?
Attachment #247050 - Flags: approval1.8.1.1+
Attachment #247050 - Flags: approval1.8.0.9?
Attachment #247050 - Flags: approval1.8.0.9+
Whiteboard: need branch patch → need branch landing
Whiteboard: need branch landing
Status: RESOLVED → VERIFIED
Flags: blocking1.9? → in-testsuite?
You need to log in before you can comment on or make changes to this bug.