356851 - nsXPConnect::ReparentAllWrappersInScope uses wrong parents.

Status: VERIFIED FIXED

(Core :: XPConnect, defect)

Description

[Boris Zbarsky [:bzbarsky]]

See bug 333697 comment 42.

This probably breaks form control access in some cases, and XUL stuff in some other cases.

Given that we landed bug 333697 on branches, we should fix this there too.

Comment 1

[Boris Zbarsky [:bzbarsky]]

This looks like a 1-line change, btw.  I just don't have the time to do the testing that would be needed...

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

See bug 333697 comment 44.

Comment 3

[Boris Zbarsky [:bzbarsky]]

See bug 333697 comment 45 and bug 333697 comment 46.

Comment 4

[Daniel Veditz [:dveditz]]

peterv: can you get this one in for us?

Comment 5

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 245580 [details] [diff] [review]
v1

r+sr=jst

Comment 7

[Reed Loden [:reed]]

As this is blocking1.8.1.1+, please either request approval1.8.1.1 on the current patch or, if needed, attach a branch version of the patch and request approval1.8.1.1 on it.

The same holds true for blocking1.8.0.9+.

Also, does this patch need to be committed to the trunk, or is it already there?

Comment 8

[Peter Van der Beken [:peterv]]

Need a new patch for branch.

Comment 9

[Reed Loden [:reed]]

(In reply to comment #8)
> Need a new patch for branch.

Can you do this, please? Code freeze is Friday.

Comment 10

[Peter Van der Beken [:peterv]]

Attachment: v1 (branch version)

Comment 11

[Daniel Veditz [:dveditz]]

Comment on attachment 247050 [details] [diff] [review]
v1 (branch version)

This patch is identical except for the line numbers. Don't normally need separate branch patches just for that.

approved for 1.8/1.8.0 branches, a=dveditz