Closed Bug 356865 Opened 18 years ago Closed 18 years ago

Remove hard-coded color:black and use -moz-activehyperlinktext for links

Categories

(SeaMonkey :: Help Documentation, defect)

PowerPC
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey1.1beta

People

(Reporter: stefanh, Assigned: stefanh)

Details

(Keywords: fixed-seamonkey1.1b)

Attachments

(2 files)

I recall that there where some discussion about this when toolkit fixed their css... Finally remembered it :)
Attached patch Fix up the cssSplinter Review
I also simplified some style rules and removed one unused class.
Attachment #242427 - Flags: superreview?(neil)
Attachment #242427 - Flags: review?(neil)
Target Milestone: --- → seamonkey1.1beta
Comment on attachment 242427 [details] [diff] [review] Fix up the css Why the 100% width?
(In reply to comment #2) >Why the 100% width? Whoops, you didn't actually change that line ;-)
So, what was the issue? We're already hardcoding a bunch of colours. I'd prefer hardcode a white background and be done with it, except that won't work with KaiRo's grand scheme of things whereby he wants to use toolkit's help on help.
(In reply to comment #4) > So, what was the issue? We're already hardcoding a bunch of colours. I'd prefer > hardcode a white background and be done with it, except that won't work with > KaiRo's grand scheme of things whereby he wants to use toolkit's help on help. See bug 274471. I recall that you pinged me on irc about it. But that was a long time ago of course :-)
Attachment #242427 - Flags: superreview?(neil)
Attachment #242427 - Flags: superreview+
Attachment #242427 - Flags: review?(neil)
Attachment #242427 - Flags: review+
Comment on attachment 242427 [details] [diff] [review] Fix up the css This is just some simple css cleanup in help.
Attachment #242427 - Flags: approval-seamonkey1.1b?
Comment on attachment 242427 [details] [diff] [review] Fix up the css a=me for 1.1b
Attachment #242427 - Flags: approval-seamonkey1.1b? → approval-seamonkey1.1b+
Whiteboard: [checkin needed] into trunk/branch
Attached patch Branch diffSplinter Review
Here's a branch diff. The trunk patch doesn't apply on the 1.8 version of the file.
Checked in by Mark B (trunk/branch).
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed] into trunk/branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: