Closed
Bug 356865
Opened 18 years ago
Closed 18 years ago
Remove hard-coded color:black and use -moz-activehyperlinktext for links
Categories
(SeaMonkey :: Help Documentation, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey1.1beta
People
(Reporter: stefanh, Assigned: stefanh)
Details
(Keywords: fixed-seamonkey1.1b)
Attachments
(2 files)
2.52 KB,
patch
|
neil
:
review+
neil
:
superreview+
kairo
:
approval-seamonkey1.1b+
|
Details | Diff | Splinter Review |
2.29 KB,
patch
|
Details | Diff | Splinter Review |
I recall that there where some discussion about this when toolkit fixed their css... Finally remembered it :)
Assignee | ||
Comment 1•18 years ago
|
||
I also simplified some style rules and removed one unused class.
Attachment #242427 -
Flags: superreview?(neil)
Attachment #242427 -
Flags: review?(neil)
Assignee | ||
Updated•18 years ago
|
Target Milestone: --- → seamonkey1.1beta
Comment 2•18 years ago
|
||
Comment on attachment 242427 [details] [diff] [review]
Fix up the css
Why the 100% width?
Comment 3•18 years ago
|
||
(In reply to comment #2)
>Why the 100% width?
Whoops, you didn't actually change that line ;-)
Comment 4•18 years ago
|
||
So, what was the issue? We're already hardcoding a bunch of colours. I'd prefer hardcode a white background and be done with it, except that won't work with KaiRo's grand scheme of things whereby he wants to use toolkit's help on help.
Assignee | ||
Comment 5•18 years ago
|
||
(In reply to comment #4)
> So, what was the issue? We're already hardcoding a bunch of colours. I'd prefer
> hardcode a white background and be done with it, except that won't work with
> KaiRo's grand scheme of things whereby he wants to use toolkit's help on help.
See bug 274471. I recall that you pinged me on irc about it. But that was a long time ago of course :-)
Updated•18 years ago
|
Attachment #242427 -
Flags: superreview?(neil)
Attachment #242427 -
Flags: superreview+
Attachment #242427 -
Flags: review?(neil)
Attachment #242427 -
Flags: review+
Assignee | ||
Comment 6•18 years ago
|
||
Comment on attachment 242427 [details] [diff] [review]
Fix up the css
This is just some simple css cleanup in help.
Attachment #242427 -
Flags: approval-seamonkey1.1b?
Comment 7•18 years ago
|
||
Comment on attachment 242427 [details] [diff] [review]
Fix up the css
a=me for 1.1b
Attachment #242427 -
Flags: approval-seamonkey1.1b? → approval-seamonkey1.1b+
Assignee | ||
Updated•18 years ago
|
Whiteboard: [checkin needed] into trunk/branch
Assignee | ||
Comment 8•18 years ago
|
||
Here's a branch diff. The trunk patch doesn't apply on the 1.8 version of the file.
Assignee | ||
Comment 9•18 years ago
|
||
Checked in by Mark B (trunk/branch).
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: fixed-seamonkey1.1b
Resolution: --- → FIXED
Whiteboard: [checkin needed] into trunk/branch
You need to log in
before you can comment on or make changes to this bug.
Description
•