357007 - a bit better handling for namespaced attributes

Status: RESOLVED INVALID

(Core :: CSS Parsing and Computation, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

The namespace of the attributes isn't handled for example in HasAttributeDependentStyle.
I'd like to change this, so that implementing xml:id and
DOM 3 setIdAttribute* efficiently would be a bit simpler.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: something like this

Basically just adding PRInt32 aNamespaceID parameter to few methods and
using it whenever using aAttribute parameter too.
The changes to nsCSSFrameConstructor.cpp fixes two other cases when namespaced attributes might not be handled properly.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

HasAttributeDependentStyle is just an optimization.  Are there really enough cases where pages use multiple attributes of the same name to make the extra code worthwhile?

Comment 3

[Boris Zbarsky [:bzbarsky]]

smaug, I have no idea when I would be able to get to this review.  :(

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

I'll make some tests to see how much this improves the performance when there are multiple IDs.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Smaug, got any test results here?

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

I included this as a part of the current xml:id patch.
namespaces are needed there anyway and calls like GetIDAttributeName will be
namespace aware.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Want to mark the dep?

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

This was for xml:id, I think, and that was removed.