Closed Bug 357014 Opened 14 years ago Closed 14 years ago
.warn On About Config isn't always remembered .
I'm filing this here as that's where the original bug that implemented browser.warnOnAboutConfig was (bug 339720). Using the following method causes the state of browser.warnOnAboutConfig to be forgotten: 1) Bring up about:config 2) uncheck "Show this warning next time" 3) submit -> config screen displayed. 4) New tab or window 5) bring up about:config again, config screen is displayed straight away. 6) New tab or window 7) bring up about:config again, the warning screen is displayed instead of the config screen. At step 5) browser.warnOnAboutConfig is reset to true, I think this will also happen with restarting the app. I think this section is the problem: http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/xpfe/global/resources/content/config.js&rev=1.27&mark=368-372#335 as its assuming that showWarningNextTime has been set to the preference value but the xul always initialises it to true: http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/content/config.xul#86
dumping in SeaMonkey since FF doesn't have this bug (yet :)) and so we get SeaMonkey flags.
Assignee: nobody → cst
Component: XP Miscellany → XP Apps: GUI Features
Product: Core → Mozilla Application Suite
QA Contact: brendan → guifeatures
This should block beta (it'd be nice to get the fixed solution tested) if not final.
Yeah, the code might as well unconditionally set the pref at that point.
I understand now. It's not at all related to having about:config open at the same time in multiple places. Patch in a few minutes.
I could have done this another way, but this keeps all callees as just one simple line and doesn't add any new one-line functions. Not setting "sr?" because I don't think this patch requires it.
Comment on attachment 242619 [details] [diff] [review] What I said, but fixed ;-) Oh. Because you can't actually check the box once it's been unchecked. Ok :)
Attachment #242619 - Flags: review?(cst) → review+
Assignee: cst → neil
Fix checked in to trunk.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment on attachment 242619 [details] [diff] [review] What I said, but fixed ;-) Neil landed with a=me.
Attachment #242619 - Flags: approval-seamonkey1.1b+
You need to log in before you can comment on or make changes to this bug.