357050 - ja/ja-JP-mac Firefox will show blank warning dialog when we visit ssl2 site (ssl3/tls too when we disable ssl3/tls)

Status: VERIFIED FIXED

(Mozilla Localizations :: ja / Japanese, defect)

Description

[dynamis (Tomoya ASAI)]

When we visit ssl2 site, will show warning message:
Alert
[!] Minefield can't connect securely to *** because the site uses an older,
insecure version of the SSL protocol.
[OK]

but ja/ja-JP-mac Firefox will show blank dialog.
# I'll attach the screeenshot
examples of ssl2 site:
https://homepageb.nifty.com/
https://www.sonyfamilyclub.co.jp/ 

The cause of this is Firefox don't support partial replacements but we ja/ja-JP-mac omit %1$S and only contains %2$S in SSL2_Disabled:
http://lxr.mozilla.org/l10n-mozilla1.8/source/ja/security/manager/chrome/pipnss/pipnss.properties#340

%1$S will be replaced with "Firefox" (or "Bon Echo") and in japanese it's more natural to omit it and we omitted but Firefox 2 don't support it.

So, we should add %1$S into SSL2_Disabled. 
Same problem exists in SSL_Disabled.

I'll attach patch to change ja locale file.

Comment 1

[dynamis (Tomoya ASAI)]

Attachment: blank warning dialog with ja Firefox 2.0 RC3

Comment 2

[dynamis (Tomoya ASAI)]

Attachment: add $1%S in SSL_Disabled and SSL2_Disabled

This dialog is not security relating warning dialog and very important.
So, L10N cvs is already closed but please give approval to check in this fix before Firefox 2 final (not for 2.0.0.1).
# requesting blocking-firefox2 too

Comment 3

[Axel Hecht [:Pike]]

Dan, I guess we could use your comment on this one, too.

Comment 4

[dynamis (Tomoya ASAI)]

Attachment: warning dialog with the patch (tested with langpack)

With above patch dialog will be shown correctlly.
Just adding "%1$S" (and one japanese text) and risk is tiny.

We already find users who have trouble with ssl2 site and more users will be confused if ja Firefox will show blank warning. Sorry very very late but we're very happy if this fix is allowed.

Comment 5

[Gen Kanai [:gen]]

It's past midnight here so I'll need a few more hours to get a consensus from the Japan team on the severity of this bug.  John's in town as well so we'll be able to get his counsel as well.  I will update everyone as soon as I have more information.

Comment 6

[dynamis (Tomoya ASAI)]

Sorry, summary was not clear enough.

Not only ssl2 but also ssl3/tls site will show blank warning dialog if we disabled ssl. So, if you think this problem effects only on ssl2 site and minor problem, please reconsider.

If we release Firefox 2 without this fix, we have to annouce about this. In that case, not only those who use ssl2 site (and those who disable ssl3/tls) will be confused, but also all the Japanese users will be disappointed about this and Firefox brand will be damaged in Japan.
# Bloggers will add notice about this bug on their post about Fx 2 release.
# That will throw a wet blanket on Firefox 2 celeblation. :(

So if you think this is minor problem relating only a few users, please reconsider.

(In reply to comment #0)
> So, we should add %1$S into SSL2_Disabled. 
> Same problem exists in SSL_Disabled.

This means that this problem will also happen when we visit ssl3/tls site if we disabled ssl/tls in the pref dialog.

Comment 7

[Gen Kanai [:gen]]

Mozilla Japan does not view this as blocking firefox2.  Let's get the fix into the first update.  Thanks for everyone's attention to this.

Comment 8

[dynamis (Tomoya ASAI)]

As Gen wrote, we mozilla japan don't require this bug fixed before Firefox 2.
Thanks everyone.

Remove blocking-firefox 2 request and change approval request target.

Comment 9

[Gen Kanai [:gen]]

I'd like to be sure we do not forget this bug for 1.8.1.1 if possible.  Can we have this moved into the trunk yet?

Comment 10

[Axel Hecht [:Pike]]

Comment on attachment 242587 [details] [diff] [review]
add $1%S in SSL_Disabled and SSL2_Disabled

Yeah, we should do this for 1.8.1.1.

Please add the fixed1.8.1.1 and verified1.8.1.1 keywords to note your process of landing and verifying this patch.

Comment 11

[dynamis (Tomoya ASAI)]

Attachment: use $1%0.S in SSL_Disabled and SSL2_Disabled

If we use '$1%0.S' in the entities, we can output nothing for first replacement and this is a patch to use it.
# thanks information, Axel

requesting approval1.8.1.1

Comment 12

[dynamis (Tomoya ASAI)]

Attachment: warning dialog with the new patch (tested with langpack)

This is the screenshot of the ssl warning window with new patch using '$1%0.S'.

note:
Previous screenshot (attachment 242589 [details]) was the dialog using "SSL2_Disabled" but this screenshot is one using "SSL_Disabled". This will be shown when we disable ssl3/tls in the pref window and try to access ssl3/tls site.
# thg site I first pointed stopped using ssl2 and I know no ssl2 site now ;)

Comment 13

[Axel Hecht [:Pike]]

Comment on attachment 246263 [details] [diff] [review]
use $1%0.S in SSL_Disabled and SSL2_Disabled

[ja/ja-JP-mac] approval to fix pipnss.properties the right way and to not display Firefox in the dialog as should be per language patterns.

Comment 14

[Axel Hecht [:Pike]]

[mass-verified1.8.1.1 message, filter on this if you need to]

This bug has an approved patch, but not the verified1.8.1.1 keyword.

Please make sure that the approved patch is landed (add the fixed1.8.1.1 keyword then) and tested. If you verified that the bug in question is indeed fixed on the 1.8 branch nightlies, please add the verified1.8.1.1 keyword.

We need to get the QA activities around Firefox 2.0.0.1 up to speed so that we can feel good about releasing this update.

Comment 15

[dynamis (Tomoya ASAI)]

I verified the fix with latest tinderbox builds.

-> RESOLVED FIXED verified1.8.1.1