357096 - Preferences -> Privacy & Security -> Popup Windows misses a few accesskeys

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Giacomo Magnini]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; it; rv:1.8.0.7) Gecko/20060913 Fedora/1.5.0.7-1.fc5 Firefox/1.5.0.7 pango-text
Build Identifier: 

Play a sound -> P
Display an icon... -> D

While in there, use v for Preview (as in prefs->navigator->downloads and in prefs->mailnews->notifications).

Reproducible: Always

Comment 1

[Giacomo Magnini]

Attachment: This should be ok

Comment 2

[[e-mail]]

Comment on attachment 242618 [details] [diff] [review]
This should be ok

> <!ENTITY selectSound.label              "Select...">
Interestingly Mail & Newsgroups Notifications uses _B_rowse...

Comment 3

[Giacomo Magnini]

Attachment: Neil, do you like this one better?

Comment 4

[[e-mail]]

Comment on attachment 242634 [details] [diff] [review]
Neil, do you like this one better?

> <!ENTITY popupBlock.label               "Block unrequested popup windows">
>-<!ENTITY popupBlock.accesskey           "B">
>+<!ENTITY popupBlock.accesskey           "k">
Not sure... maybe this should be w, unless IanN has any better ideas...

>+<!ENTITY selectSound.label              "Browse...">
>+<!ENTITY selectSound.accesskey          "B">

Comment 5

[Ian Neal]

Comment on attachment 242634 [details] [diff] [review]
Neil, do you like this one better?

>Index: suite/locales/en-US/chrome/common/pref/pref-popups.dtd
>===================================================================
> <!ENTITY popupBlock.label               "Block unrequested popup windows">
>-<!ENTITY popupBlock.accesskey           "B">
>+<!ENTITY popupBlock.accesskey           "k">
My preference is to leave this as "B"
> 
> <!ENTITY popupExceptions.label          "Allowed Sites...">
> <!ENTITY popupExceptions.accesskey      "A">
> 
> <!ENTITY whenBlock.description          "When a popup window has been blocked:">
> <!ENTITY playSound.label                "Play a sound:">
>+<!ENTITY playSound.accesskey            "P">
Possibly use "s" here and "P" later on for "Preview"
> 
>-<!ENTITY selectSound.label              "Select...">
>-<!ENTITY selectSound.accesskey          "e">
>+<!ENTITY selectSound.label              "Browse...">
>+<!ENTITY selectSound.accesskey          "B">
Possibly use "r" here

> <!ENTITY previewSound.label             "Preview">
>-<!ENTITY previewSound.accesskey         "r">
>+<!ENTITY previewSound.accesskey         "v">
Possibly use "P" here or "e" if "P" is still used for "Play a sound:"

Comment 6

[Giacomo Magnini]

Attachment: What Ian asked.

Comment 7

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Fixed on trunk and branch.