Closed Bug 357271 Opened 17 years ago Closed 17 years ago

Pref panel: Advanced -> Keyboard Navigation can break on localized build

Categories

(SeaMonkey :: Preferences, defect)

Product:
SeaMonkey
Component:
Preferences
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: prometeo.bugs, Assigned: prometeo.bugs)

Details

(Keywords: fixed-seamonkey1.1b)

Attachments

(1 file, 1 obsolete file)

What Neil asked.
1.17 KB, patch
prometeo.bugs
: review+
jag+mozilla
: superreview+
kairo
: approval-seamonkey1.1b+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20061019 SeaMonkey/1.5a
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20061019 SeaMonkey/1.5a

The tabNavigationTextboxes,label has no problems in English, but hte translated version in Italian, for example, is much longer, and it makes the pref panel look cut. This can be a problem in other localizations as well.

Reproducible: Always
Attached patch This should be enough (obsolete) — — Splinter Review 

        Attachment #242762 -
        Flags: review?(neil)

    
  

        Attachment #242762 -
        Flags: approval-seamonkey1.1b?

    
    

    
  
Comment on attachment 242762 [details] [diff] [review]
This should be enough

You might as well do tabNavigationDesc too?

        Attachment #242762 -
        Flags: review?(neil) → review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        What Neil asked.
        — 
          — Splinter Review
      

    


  

        Attachment #242762 -
        Attachment is obsolete: true

        Attachment #242777 -
        Flags: superreview?(jag)

        Attachment #242777 -
        Flags: review+

        Attachment #242777 -
        Flags: approval-seamonkey1.1b?

        Attachment #242762 -
        Flags: approval-seamonkey1.1b?

    
  

        Attachment #242777 -
        Flags: superreview?(jag) → superreview+

    
  
Whiteboard: [checkin needed]

    
  
Status: UNCONFIRMED → NEW
Ever confirmed: true

    
  
Assignee: prefs → giacomo.magnini

    
    

    
  
Comment on attachment 242777 [details] [diff] [review]
What Neil asked.

a=me for 1.1b

        Attachment #242777 -
        Flags: approval-seamonkey1.1b? → approval-seamonkey1.1b+

    
    

    
  
Checked into trunk:

Checking in suite/common/pref/pref-keynav.xul;
/cvsroot/mozilla/suite/common/pref/pref-keynav.xul,v  <--  pref-keynav.xul
new revision: 1.8; previous revision: 1.7

and branch:

Checking in pref-keynav.xul;
/cvsroot/mozilla/xpfe/components/prefwindow/resources/content/Attic/pref-keynav.xul,v  <--  pref-keynav.xul
new revision: 1.6.6.1; previous revision: 1.6

Assuming this is fixed.
Status: NEW → RESOLVED
Closed: 17 years ago
Keywords: fixed-seamonkey1.1b
Resolution: --- → FIXED
Whiteboard: [checkin needed]

          You need to log in
          before you can comment on or make changes to this bug.